Ticket #9765 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

matrix2.pyx: replace "x < 1e-15" by "abs(x) < 1e-15"

Reported by: jhpalmieri Owned by: AlexGhitza
Priority: blocker Milestone: sage-4.5.3
Component: algebra Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Mitesh Patel
Authors: John Palmieri Merged in: sage-4.5.3.alpha2
Dependencies: Stopgaps:

Description

In matrix2.pyx, there is a doctest (line 6406): 

            sage: all(imag(e) < 1.1e-15 for e in eigs)

We should replace "imag(e)" by "abs(imag(e))".

The attached patch depends on #9760.

Attachments

trac_9765-matrix2-abs.patch Download (1.2 KB) - added by jhpalmieri 3 years ago.

Change History

Changed 3 years ago by jhpalmieri

comment:1 Changed 3 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by mpatel

  • Status changed from needs_review to positive_review
  • Reviewers set to Mitesh Patel

The test still passes on bsd, redhawk, sage, and t2.math.

comment:3 Changed 3 years ago by mpatel

  • Priority changed from major to blocker
  • Milestone changed from sage-4.6 to sage-4.5.3

comment:4 Changed 3 years ago by mpatel

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.5.3.alpha2
Note: See TracTickets for help on using tickets.