Ticket #9697 (closed defect: fixed)
DS_Store garbage in flint spkg
| Reported by: | rlm | Owned by: | pdehaye |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.4 |
| Component: | packages: standard | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Karl-Dieter Crisman |
| Authors: | Paul-Olivier Dehaye | Merged in: | sage-5.4.rc2 |
| Dependencies: | Stopgaps: |
Description (last modified by jdemeyer) (diff)
Change History
comment:2 Changed 7 months ago by pdehaye
- Owner changed from tbd to pdehaye
- Milestone set to sage-5.4
comment:3 Changed 7 months ago by pdehaye
Suggested fix: http://boxen.math.washington.edu/home/pdehaye/spkg/flint-1.5.2.p2.spkg
Beware, this is my first spkg. I removed the offending file, modified SPKG.txt, and the mercurial log. I then made the spkg using sage _5.0_ as this is the last version I have running on my system. It looks like sage-spkg has not been changed since, so that should not be a problem.
comment:5 Changed 7 months ago by kcrisman
- Reviewers set to Karl-Dieter Crisman
- Authors set to Paul-Olivier Dehaye
The spkg was created correctly, as far as I can tell. You even added the tag!
This just needs formal testing on a couple machines to make sure something weird didn't accidentally happen, but looks good.
comment:7 Changed 7 months ago by kcrisman
- Status changed from needs_review to positive_review
Same on Mac OS X. I think this is ok...
comment:8 Changed 7 months ago by leif
FWIW, the .svn/ folders should get removed from the source tree anyway. [Haven't looked at the new spkg.]
comment:9 Changed 7 months ago by pdehaye
@leif: There are actually two issues: some .DS_Store are in the spkg, all having to do with bernoulli. One of those files sits inside a .svn folder, and was originally reported in this ticket. The others are in regular src/ folders, and might have been introduced when preparing the spkg.
comment:11 Changed 7 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-5.4.rc2
I have reported a similar error about flint-1.5.2.p1.spkg at https://groups.google.com/d/topic/sage-release/52Hz8-G3TWA/discussion