Ticket #9621 (closed defect: duplicate)
Fix GAP interface problem in sylow_subgroup method
|Reported by:||SimonKing||Owned by:||joyner|
|Component:||group theory||Keywords:||GAP string representation|
|Report Upstream:||N/A||Reviewers:||Simon King, Johan Sebastian Rosenkilde Nielsen, Mike Hansen|
Description (last modified by jdemeyer) (diff)
The following was reported by Kenny Brown:
sage: n = 3^2 * 7^2 sage: G = CyclicPermutationGroup(n) sage: G.sylow_subgroup(3) Traceback (most recent call last): ...
The problem is that in the sylow_subgroup method, it is attempted to get the string presentation of a permutation in GAP by calling gap.eval(...). However, GAP truncates the output. So, better use gap.eval('Print(...)') instead.
Moreover, the method uses quite generic variable names in the GAP interface. This is dangerous, as the use of variable names that any average user might choose as well can have nasty side effects.
Fixed by #10334.
Changed 3 years ago by SimonKing
- attachment trac-9621_permgroup_sylow_subgroup_with_simplification.patch added
- Authors changed from Simon King to Simon King, Johan Sebastian Rosenkilde Nielsen
- Status changed from needs_review to needs_work
- Work issues set to rebase
- Status changed from needs_work to positive_review
- Reviewers set to Mike Hansen
- Milestone changed from sage-5.0 to sage-duplicate/invalid/wontfix
- Status changed from positive_review to closed
- Description modified (diff)
- Authors Simon King, Johan Sebastian Rosenkilde Nielsen deleted
- Reviewers changed from Mike Hansen to Simon King, Johan Sebastian Rosenkilde Nielsen, Mike Hansen
- Resolution set to duplicate
- Work issues rebase deleted