Ticket #9534 (closed enhancement: fixed)
add base method for permutation groups
| Reported by: | jasonbhill | Owned by: | jasonbhill |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.7.2 |
| Component: | group theory | Keywords: | base |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Mike Hansen |
| Authors: | Jason Hill | Merged in: | sage-4.7.2.alpha4 |
| Dependencies: | #10334, #10335 | Stopgaps: |
Description (last modified by leif) (diff)
Patch to add a (working) base method for permutation groups.
Apply trac_9534-permgroup_base.patch to the Sage library.
Attachments
-
trac_9534-permgroup_base.patch
(2.1 KB) -
added by mhansen 2 years ago.
Change History
comment:2 Changed 2 years ago by mhansen
- Status changed from new to needs_review
- Reviewers set to Mike Hansen
- Description modified (diff)
- Authors changed from jasonbhill to Jason Hill
This is actually Jason's code, and it looks good to me.
comment:4 Changed 2 years ago by jdemeyer
- Dependencies set to #10334, #10335
- Description modified (diff)
comment:7 Changed 22 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.7.2.alpha0
comment:8 Changed 22 months ago by jdemeyer
- Status changed from closed to new
- Resolution fixed deleted
- Merged in sage-4.7.2.alpha0 deleted
Unmerged because of an issue with #10335.
comment:10 Changed 22 months ago by jdemeyer
- Status changed from needs_review to positive_review
- Milestone changed from sage-4.7.2 to sage-pending
comment:11 Changed 20 months ago by leif
- Description modified (diff)
Does this now have to be rebased on (the rebased) #10335?
In case it does, one should set it to "needs work", otherwise the milestone should be changed to Sage 4.7.2 again.
comment:12 Changed 20 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.7.2.alpha4
- Milestone changed from sage-pending to sage-4.7.2
Note: See
TracTickets for help on using
tickets.
The existing base method returned "Integer Ring" for all permutation groups as it was inherited from ParentWithBase?. This new base method uses GAP's base from stabilizer chain method to return an actual base, with an optional seed.
The patch was placed in the combinat queue as it depends on Mike Hansen's domain modifications.