Ticket #9452 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

strip_automount_prefix() is useless

Reported by: rlm Owned by: tbd
Priority: major Milestone: sage-4.7
Component: distribution Keywords:
Cc: was Work issues:
Report Upstream: N/A Reviewers: William Stein
Authors: Jason Grout Merged in: sage-4.7.alpha1
Dependencies: Stopgaps:

Description

We wrote the strip_automount_prefix() function for sage-test to get around problems with automounted file system having wierd mount points. Unfotunately the strip_automount_prefix() does not work at all!

Here is a patch:

% diff sage-test.old sage-test.new 20c20 < return strip_automount_prefix(os.path.abspath(x)) ---

return os.path.abspath(x)

57c57 < f = g[len(SAGE_ROOT)+1:] ---

f = g[g.find(SAGE_ROOT)+len(SAGE_ROOT)+1:]

%

You can remove - or deprecate - the function strip_automount_prefix().

Attachments

trac-9452-strip_automount_prefix.patch Download (1.4 KB) - added by jason 2 years ago.

Change History

Changed 2 years ago by jason

comment:1 Changed 2 years ago by jason

  • Authors set to Jason Grout

comment:2 Changed 2 years ago by jason

  • Cc was added
  • Status changed from new to needs_review

comment:3 Changed 2 years ago by was

  • Status changed from needs_review to positive_review

comment:4 Changed 2 years ago by jdemeyer

  • Reviewers set to William Stein
  • Milestone changed from sage-4.6.2 to sage-feature

What exactly is the problem that this patch is supposed to fix? The description is very unclear...

comment:5 Changed 2 years ago by was

This patch is undoing a mysterious "fix" from a long time ago, which was required on some obscure filesystem somewhere.

comment:6 Changed 2 years ago by jdemeyer

  • Milestone changed from sage-feature to sage-4.7

comment:7 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.alpha1
Note: See TracTickets for help on using tickets.