Ticket #9403 (closed enhancement: fixed)
preimage method in NumberFieldHomomorphism_im_gens
| Reported by: | jeremywest | Owned by: | AlexGhitza |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.5.2 |
| Component: | algebra | Keywords: | number field, embedding, homomorphism, preimage |
| Cc: | ebeyerstedt, fwclarke, davidloeffler | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Aly Deines |
| Authors: | Jeremy West | Merged in: | sage-4.5.2.alpha1 |
| Dependencies: | Stopgaps: |
Description
I am adding a preimage method in the NumberFieldHomomorphism?_im_gens class. There may be a better or more general place to put this, but we need it for the descend_to method in EllipticCurve? so I am putting it there for now.
Attachments
-
trac_9403-preimage.patch
(2.7 KB) -
added by jeremywest 3 years ago.
- A preimage method for NumberFieldHomomorphism?
-
trac_9403-new.patch
(3.1 KB) -
added by ebeyerstedt 3 years ago.
- Replaces previous patch.
-
trac_9403-error_handling.patch
(3.2 KB) -
added by jeremywest 3 years ago.
- Fixes error handling message, replaces all previous patches.
Change History
comment:1 Changed 3 years ago by jeremywest
- Cc ebeyerstedt added
- Status changed from new to needs_work
Changed 3 years ago by jeremywest
-
attachment
trac_9403-preimage.patch
added
A preimage method for NumberFieldHomomorphism?
comment:2 Changed 3 years ago by jeremywest
- Status changed from needs_work to needs_review
I have implemented the preimage method including documentation and tests. I just need a review now. Let me know if this should go somewhere better.
comment:3 Changed 3 years ago by ebeyerstedt
The new patch changes each usage of .vector_space to .absolute_vector_space. Also added a doctest.
comment:7 Changed 3 years ago by jeremywest
I changed the error message that is returned when the input is not in the image of the homomorphism so that, rather than a message about solving a matrix equation, it gives a message about the input not being in the image.
comment:8 Changed 3 years ago by davidloeffler
- Status changed from positive_review to needs_work
If you really must upload new patches to an already positively reviewed ticket, you *must* put the status back to "needs review".
Changed 3 years ago by jeremywest
-
attachment
trac_9403-error_handling.patch
added
Fixes error handling message, replaces all previous patches.
comment:10 Changed 3 years ago by ddrake
David -- can you review the newest patch? If this ticket can get a positive review, then it and #9384 can get into 4.5.2.
comment:12 Changed 3 years ago by ddrake
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.5.2.alpha1
Please include the ticket number in your commit messages! Also, Jeremy, you might want to set your username in your .hgrc file -- your patch has a username of "jeremy@…".
comment:14 Changed 3 years ago by mpatel
- Reviewers set to Aly Deines
I'm entering a guess for the Reviewer(s) field. Please correct me if I'm wrong.
