Ticket #9375 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

more documentation & doctests for BalancedTree, BarbellGraph, BubbleSortGraph, BullGraph, ChvatalGraph

Reported by: mvngu Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.5.2
Component: graph theory Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Nathann Cohen
Authors: Minh Van Nguyen Merged in: sage-4.5.2.alpha0
Dependencies: Stopgaps:

Description

As the subject says.

Prerequisite: #9373

Attachments

trac_9375-graph-doctests.patch Download (26.7 KB) - added by mvngu 3 years ago.

Change History

Changed 3 years ago by mvngu

comment:1 Changed 3 years ago by mvngu

  • Status changed from new to needs_review
  • Authors set to Minh Van Nguyen

comment:2 follow-up: ↓ 3 Changed 3 years ago by ncohen

Excellent ! You can set this one to "positive review" immediately after #9375 :-)

One unimportant detail, though... You used subgraph_search in your doctests, the follwing way :

sage: s_K = g.subgraph_search(K_n1, induced=True) 
sage: s_P = g.subgraph_search(P_n2, induced=True) 
sage: K_n1.is_isomorphic(s_K) 

Well, subgraph_search should of course *always* return subgraphs isomorphic to S_k. Actually, the order of the vertices should even be the same, but when it finds nothing, it returns a None, which is_isomorphic may not like... It's not really a problem in this case, as this would report a doctest failure anyway :-)

Nathann

comment:3 in reply to: ↑ 2 Changed 3 years ago by mvngu

Replying to ncohen:

You can set this one to "positive review" immediately after #9375 :-)

I don't understand what you mean. Care to elaborate on this point?

comment:4 Changed 3 years ago by ncohen

  • Status changed from needs_review to positive_review

Sorry, I meant #9373 :-)

It was just to avoid having a ticket A depending on B such that a is positively reviewed while B is not.

Nathann

comment:5 Changed 3 years ago by mpatel

  • Status changed from positive_review to closed
  • Reviewers set to Nathann Cohen
  • Resolution set to fixed
  • Merged in set to sage-4.5.2.alpha0
Note: See TracTickets for help on using tickets.