Ticket #9367 (closed defect: fixed)
S_unit return type is incorrect
| Reported by: | syazdani | Owned by: | davidloeffler |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-5.0 |
| Component: | number fields | Keywords: | S_units |
| Cc: | mjo | Work issues: | |
| Report Upstream: | N/A | Reviewers: | David Loeffler |
| Authors: | Michael Orlitzky | Merged in: | sage-5.0.beta9 |
| Dependencies: | Stopgaps: |
Description (last modified by davidloeffler) (diff)
In some old versions of Sage, the S-unit commands returned values with the wrong parent:
sage: _.<x>=QQ[] sage: L.<alpha>=NumberField(x^3+x+1) sage: p=L.S_units([ L.ideal(7) ] ) sage: p[0].parent() Rational Field
The correct output should be
Number Field in alpha with defining polynomial x^3 + x + 1
This is now fixed, so we should doctest to make sure it doesn't get broken again.
Apply sage-trac_9367.patch
Attachments
-
patch-9367.patch
(787 bytes) -
added by syazdani 3 years ago.
- Fixes the return type.
-
sage-trac_9367.patch
(1.0 KB) -
added by mjo 17 months ago.
- Add a doctest for the correct behavior.
Change History
Changed 3 years ago by syazdani
-
attachment
patch-9367.patch
added
Changed 17 months ago by mjo
-
attachment
sage-trac_9367.patch
added
Add a doctest for the correct behavior.
comment:1 Changed 17 months ago by mjo
- Cc mjo added
- Status changed from new to needs_review
- Authors set to Michael Orlitzky
It looks like someone beat you to it! I get the correct answer with 4.8.alpha6, so I've added a doctest for it.
comment:2 Changed 15 months ago by davidloeffler
- Priority changed from major to minor
- Reviewers set to David Loeffler
- Status changed from needs_review to positive_review
- Description modified (diff)
- Milestone set to sage-5.0
Apply sage-trac_9367.patch
(for patchbot).
Note: See
TracTickets for help on using
tickets.
Fixes the return type.