Ticket #9355 (closed defect: fixed)
100% coverage for quadratic_forms
| Reported by: | annahaensch | Owned by: | mvngu |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.5.2 |
| Component: | documentation | Keywords: | quadratic forms |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | David Loeffler |
| Authors: | Anna Haensch | Merged in: | sage-4.5.2.alpha0 |
| Dependencies: | Stopgaps: |
Description
Attachments
-
trac_9355.patch
(1.4 KB) -
added by annahaensch 3 years ago.
-
trac_9355_loads_dumps.patch
(1.7 KB) -
added by annahaensch 3 years ago.
- Apply on top of trac_9355.patch
Change History
comment:2 Changed 3 years ago by davidloeffler
- Status changed from needs_review to needs_work
- Reviewers set to David Loeffler
- Work issues set to loads/dumps doctests
I tried this, and it is fine as far as it goes but sage -coverage still grumbles about the lack of a TestSuite.run() doctest in genera/genus.py. In fact the two classes in that file don't derive from SageObject? (although they probably should), so the TestSuite? machinery doesn't work on them; but it would be good to have loads/dumps doctests for these classes. With those added I would be happy for this to go in.
(A much bigger step forward would be adding the quadratic forms code to the reference manual, but that's a separate issue.)
Changed 3 years ago by annahaensch
-
attachment
trac_9355_loads_dumps.patch
added
Apply on top of trac_9355.patch
comment:4 Changed 3 years ago by davidloeffler
- Status changed from needs_review to positive_review
OK, that looks fine.
Note: See
TracTickets for help on using
tickets.
