Ticket #9318 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Fix S-Box CNF generation for non permutations

Reported by: malb Owned by: AlexGhitza
Priority: major Milestone: sage-4.5.2
Component: algebra Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Yann Laigle-Chapuy
Authors: Martin Albrecht Merged in: sage-4.5.2.alpha0
Dependencies: Stopgaps:

Description

This should work: 

sage: o = range(8) + range(8)
sage: shuffle(o)
sage: S = mq.SBox(o)
sage: S.is_permutation()
False

sage: len(S.cnf()) == 3*2^4
True

Attachments

sbox_fixes.patch Download (1.5 KB) - added by malb 3 years ago.

Change History

Changed 3 years ago by malb

comment:1 Changed 3 years ago by ylchapuy

Applies fine to sage-4.5.alpha0, and does the job. If it was "needs_review" I would give a positive one...

comment:2 Changed 3 years ago by malb

  • Status changed from new to needs_review

comment:3 Changed 3 years ago by malb

  • Status changed from needs_review to positive_review
  • Reviewers set to Yann Laigle-Chapuy

sorry, my bad

comment:4 Changed 3 years ago by mpatel

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.5.2.alpha0
Note: See TracTickets for help on using tickets.