Ticket #9308 (closed defect: invalid)

Opened 3 years ago

Last modified 8 months ago

Add an spkg-check file for GnuTLS

Reported by: drkirkby Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: spkg-check Keywords:
Cc: leif, jhpalmieri, pjeremy Work issues:
Report Upstream: N/A Reviewers: David Kirkby, Jeroen Demeyer
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by mariah) (diff)

GnuTLS is one of the many standard packages in Sage (see #9281 for a list), which do not have a spkg-check file. This means that if one builds Sage with the environment variable SAGE_CHECK set to "yes", no self-tests of the package will be run. This is silly, as GnuTLS has a test suite.

After adding the required file, the test suite is run and at least on my OpenSolaris laptop, passes all tests.

Dave

---

Ticket #9975 supercedes this ticket. When ticket #9975 is closed, this ticket may be closed.

Attachments

9308.patch Download (1.3 KB) - added by drkirkby 3 years ago.
Mercurial patch to add an spkg-check to enable self-tests

Change History

comment:1 Changed 3 years ago by drkirkby

  • Status changed from new to needs_review
  • Authors set to David Kirkby

After this is added, we can see the results - in this case all 15 tests pass, on a Sony laptop running OpenSolaris 06/2009. 

PASS: resume
===================
All 15 tests passed
===================
make[3]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src/tests'
make[2]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src/tests'
make[1]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src/tests'
Making check in po
make[1]: Entering directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src/po'
make[1]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src/po'
make[1]: Entering directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src'
make[1]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6/src'
Now cleaning up tmp files.
rm: Cannot remove any directory in the path of the current working directory
/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/gnutls-2.2.1.p6
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing gnutls-2.2.1.p6.spkg

The revised package may be found at

 http://boxen.math.washington.edu/home/kirkby/patches/gnutls-2.2.1.p6.spkg

Changed 3 years ago by drkirkby

Mercurial patch to add an spkg-check to enable self-tests

comment:2 Changed 3 years ago by drkirkby

  • Cc leif, jhpalmieri, pjeremy added

Again, cc'ing a few people who seem keen to improve the quality of Sage.

Dave

comment:3 Changed 2 years ago by mariah

  • Description modified (diff)

comment:4 Changed 8 months ago by jdemeyer

  • Status changed from needs_review to closed
  • Reviewers set to David Kirkby, Jeroen Demeyer
  • Milestone changed from sage-5.4 to sage-duplicate/invalid/wontfix
  • Resolution set to invalid
  • Authors David Kirkby deleted

Invalid since GNUTLS is no longer part of Sage.

Note: See TracTickets for help on using tickets.