Ticket #9216 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Bring doc coverage of groups/group.pyx to 100%

Reported by: slabbe Owned by: slabbe
Priority: major Milestone: sage-4.5.2
Component: documentation Keywords:
Cc: sage-combinat Work issues:
Report Upstream: N/A Reviewers: Franco Saliola
Authors: Sébastien Labbé Merged in: sage-4.5.2.alpha0
Dependencies: Stopgaps:

Description


Attachments

trac_9216_doc_group_pyx-sl.patch Download (4.6 KB) - added by slabbe 3 years ago.

Change History

Changed 3 years ago by slabbe

comment:1 Changed 3 years ago by slabbe

  • Cc sage-combinat added
  • Status changed from new to needs_review
  • Authors set to Sébastien Labbé

comment:2 Changed 3 years ago by saliola

  • Status changed from needs_review to positive_review
  • Reviewers set to Franco Saliola

ok.

reviewed against 4.4.3.

comment:3 Changed 3 years ago by rlm

  • Status changed from positive_review to needs_work

Perhaps you should have an example of __contains__ working, not just failing. Should just return true or false, right?

-- RLM, and the audience at SD 23.

comment:4 Changed 3 years ago by was

  • Status changed from needs_work to positive_review

Oops -- WJP just pointed out that I was wrong.

comment:5 Changed 3 years ago by mpatel

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.5.2.alpha0
Note: See TracTickets for help on using tickets.