Ticket #9091 (closed defect: fixed)
check_file() in latex.py spits out warnings every time
| Reported by: | rbeezer | Owned by: | jason |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.4.4 |
| Component: | misc | Keywords: | |
| Cc: | nthiery, jhpalmieri | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Nicolas M. Thiéry |
| Authors: | Rob Beezer | Merged in: | sage-4.4.4.alpha0 |
| Dependencies: | Stopgaps: |
Description
In sage/misc/latex.py the check_file() routine has a mis-aligned block which will issue the more_info string whenever it is called, even if the file exists.
Attachments
-
trac_9091-latex-check-file.patch
(729 bytes) -
added by rbeezer 3 years ago.
-
trac_9091-latex-check-file-v2.patch
(1.1 KB) -
added by rbeezer 3 years ago.
Change History
comment:1 Changed 3 years ago by rbeezer
- Cc nthiery, jhpalmieri added
- Status changed from new to needs_review
comment:2 follow-up: ↓ 3 Changed 3 years ago by nthiery
- Status changed from needs_review to needs_work
- Reviewers set to Nicolas M. Thiéry
Hi Robert,
Oops, how did that one get through without breaking the tests?
I am all for the change. Please add a test exhibiting the (now fixed) problem to avoid later regression; then, if all test pass, you may set a positive review on my behalf.
comment:3 in reply to: ↑ 2 Changed 3 years ago by rbeezer
Replying to nthiery:
Oops, how did that one get through without breaking the tests?
I think almost everywhere it gets exercised, it is marked "# random." I did have it messing up on my doctests on the latex() routines, which is how I caught it.
Please add a test exhibiting the (now fixed) problem to avoid later regression; then, if all test pass, you may set a positive review on my behalf.
I knew that was too easy - totally forgot to add a test against the bug. ;-) Will do in the next day or two. Thanks for the review and the reminder.
Rob
comment:4 Changed 3 years ago by rbeezer
- Status changed from needs_work to needs_review
Version 2 self-contained patch contains a test with a file that should be in every latex distribution, plus a more_info string. So prior to this fix, the info string (and only the info string) would have printed if someone ran the optional tests and had latex installed.
As requested by the reviewer, I've marked this "positive review."
Release manager: just apply the v2 patch only.
