Ticket #9037 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

pynac fails to build on 64-bit OpenSolaris x64.

Reported by: drkirkby Owned by: drkirkby
Priority: major Milestone: sage-4.4.3
Component: porting: Solaris Keywords:
Cc: jsp Work issues:
Report Upstream: N/A Reviewers: Mike Hansen
Authors: David Kirkby Merged in: sage-4.4.3.alpha3
Dependencies: Stopgaps:

Description

The spkg-install of 'pynac' has:

if [ `uname` = "Darwin" -a "$SAGE64" = "yes" ]; then
    echo "64 bit MacIntel"
    CXXFLAGS="-m64 -O2 -g"; export CXXFLAGS
    LDFLAGS="-m64"; export LDFLAGS
fi

so obviously does not attempt to build 64-bit when SAGE64="yes", unless the operating systems is OS X.

The build actually fails on a 64-bit OpenSolaris system, as pynac tries to link to 64-bit objects, which obviously fails.

sage: An error occurred while installing pynac-0.1.12

Change History

comment:1 Changed 3 years ago by drkirkby

For other OpenSolaris issues, see #9026

comment:2 Changed 3 years ago by drkirkby

  • Cc jsp added

comment:3 Changed 3 years ago by mhansen

This should be coordinated with #8903. I can make a new spkg for this issue.

comment:4 Changed 3 years ago by mhansen

There is a new spkg at #8903 which fixes this issue.

comment:5 Changed 3 years ago by drkirkby

#8903 does not fix the issue, as it still has:

if [ `uname` = "Darwin" -a "$SAGE64" = "yes" ]; then
    echo "64 bit MacIntel"
    CXXFLAGS="-m64 -O2 -g"; export CXXFLAGS
    LDFLAGS="-m64"; export LDFLAGS
fi

I'll have to create a new package based on that at #8031.

Dave

comment:6 Changed 3 years ago by drkirkby

Oops, I mean I'll have to create a new package based on that at #8903.

comment:7 Changed 3 years ago by mhansen

  • Status changed from new to needs_review
  • Reviewers set to Mike Hansen
  • Authors set to David Kirkby

This change looks good to me and is what is done in lots of other spkgs.

comment:8 Changed 3 years ago by mhansen

  • Status changed from needs_review to positive_review

comment:9 Changed 3 years ago by was

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to 4.4.3.alpha3

comment:10 Changed 3 years ago by mvngu

  • Merged in changed from 4.4.3.alpha3 to sage-4.4.3.alpha3
  • Milestone changed from sage-4.4.4 to sage-4.4.3
Note: See TracTickets for help on using tickets.