Ticket #9036 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Graph.canonical_label(certify=True, edge_labels=True) returns a name error

Reported by: stumpc5 Owned by: jason, ncohen, rlm
Priority: minor Milestone: sage-4.5
Component: graph theory Keywords: labelled graph isomorphism
Cc: Work issues:
Report Upstream: N/A Reviewers: Nathann Cohen
Authors: Christian Stump Merged in: sage-4.5.alpha1
Dependencies: Stopgaps:

Description

The method canonical_label() for Graph and DiGraph? does not take the parameters 'certify=True' and 'edge_labels=True' at the same time: 

sage: g = Graph()                                      
sage: g.canonical_label()
Graph on 0 vertices
sage: g.canonical_label(certify=True)
(Graph on 0 vertices, {})
sage: g.canonical_label(edge_labels=True)
Graph on 0 vertices
sage: g.canonical_label(certify=True, edge_labels=True)

...

NameError: global name 'relabeling' is not defined
}}

Attachments

trac_9036_canonical_label.patch Download (2.8 KB) - added by stumpc5 3 years ago.
fixed bug in GenericGraph?.canonical_label() and updated documentation

Change History

comment:1 Changed 3 years ago by stumpc5

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by ncohen

  • Status changed from needs_review to needs_info

Hmmm... I am reaallyyyyy sorry but I do not have the slightest idea of what the function "canonical_label" exactly does... Could I ask that your patch also improves its documentation ? :-/

Nathann

Changed 3 years ago by stumpc5

fixed bug in GenericGraph?.canonical_label() and updated documentation

comment:3 Changed 3 years ago by stumpc5

  • Status changed from needs_info to needs_review

Done... I hope it is more understandable now.

Christian

comment:4 Changed 3 years ago by ncohen

  • Status changed from needs_review to positive_review

Positive review ! I can now see it was a natural thing to do, but I really didn't feel safe without understanding the function's purpose... :-)

Thank you again !

Nathann

comment:5 Changed 3 years ago by davidloeffler

  • Reviewers set to Nathann Cohen
  • Milestone set to sage-4.5

comment:6 Changed 3 years ago by rlm

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.5.alpha1
Note: See TracTickets for help on using tickets.