Ticket #9035 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

add degree argument to univariate polynomial reverse() method

Reported by: burcin Owned by: AlexGhitza
Priority: minor Milestone: sage-4.4.4
Component: basic arithmetic Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: John Cremona
Authors: Burcin Erocal Merged in: sage-4.4.4.alpha0
Dependencies: Stopgaps:

Description

Attached patch adds a degree argument to the reverse() method of univariate polynomials and wraps the methods provided by FLINT in polynomial_zmod_flint and polynomial_integer_dense_flint classes.

Attachments

trac_9035-zmod_poly_reverse.patch Download (7.1 KB) - added by burcin 3 years ago.

Change History

Changed 3 years ago by burcin

comment:1 Changed 3 years ago by burcin

  • Status changed from new to needs_review
  • Authors set to Burcin Erocal

comment:2 Changed 3 years ago by cremona

  • Status changed from needs_review to positive_review

Patch applies fine to 4.4.3.alpha0, and looks good to me.

Tests pass (I tested all files in sage/rings/polynomial plus some other random tests).

I am giving this a positive review, but wonder whether the following reverse functions should also be changed to be consistent: 

libs/ntl/ntl_GF2X.pyx:645:    def reverse(self, int hi = -2):
libs/ntl/ntl_ZZX.pyx:768:    def reverse(self, hi=None):
libs/ntl/ntl_ZZ_pEX.pyx:850:    def reverse(self, hi=None):
libs/ntl/ntl_ZZ_pX.pyx:947:    def reverse(self, hi=None):
...
rings/polynomial/polynomial_modn_dense_ntl.pyx:1005:    def reverse(self):
rings/polynomial/polynomial_modn_dense_ntl.pyx:1548:    def reverse(self):
rings/polynomial/polynomial_real_mpfr_dense.pyx:484:    def reverse(self):
...
rings/polynomial/padics/polynomial_padic_capped_relative_dense.py:840:    def reverse(self, n = None):

comment:3 Changed 3 years ago by mhansen

  • Status changed from positive_review to closed
  • Reviewers set to John Cremona
  • Resolution set to fixed
  • Merged in set to sage-4.4.4.alpha0
Note: See TracTickets for help on using tickets.