Ticket #9023 (closed defect: wontfix)

Opened 3 years ago

Last modified 3 years ago

ghmm needs compiler flag -m64 when SAGE64 is set to "yes"

Reported by: drkirkby Owned by: drkirkby
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting: Solaris Keywords:
Cc: jsp Work issues:
Report Upstream: N/A Reviewers:
Authors: David Kirkby Merged in: 4.4.4.rc0
Dependencies: Stopgaps:

Description

The spkg-install has the usual dumb code for building 64-bit on OS X.

if [ `uname` = "Darwin" -a "$SAGE64" = "yes" ]; then
   echo "64 bit MacIntel"
   CFLAGS="-O2 -g -fPIC -m64 "; export CFLAGS
   LDFLAGS="-m64"; export LDFLAGS
fi

This should be easy to fix, by removing the OS X requirement.

Attachments

ghmm-64-bit-fix.patch Download (2.6 KB) - added by drkirkby 3 years ago.
Mercurial patch to build GHMM 64-bit on any operating system.

Change History

Changed 3 years ago by drkirkby

Mercurial patch to build GHMM 64-bit on any operating system.

comment:1 Changed 3 years ago by drkirkby

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by drkirkby

  • Authors set to David Kirkby

comment:3 Changed 3 years ago by drkirkby

For other OpenSolaris issues, see #9026

comment:4 Changed 3 years ago by drkirkby

  • Cc jsp added

comment:5 Changed 3 years ago by drkirkby

  • Status changed from needs_review to needs_work

I'm not happy with this - are reverting to needs work. It appears to be linking to a 32-bit library.

Dave

comment:6 Changed 3 years ago by drkirkby

  • Status changed from needs_work to needs_review
  • Summary changed from ghmm is buiding 32-bit on OpenSolaris x64 even when SAGE64 is set to "yes" to ghmm needs compiler flag -m64 when SAGE64 is set to "yes"

I've decided to revert this back to 'needs review' and change the title slightly. The reason is that the patch, whilst not sufficient for a 64-bit build, does go some way to improving the situation, as objects are now created 64-bit. There's still a problem linking with the wrong library, which needs to be resolved. However, the attached patch may allow us to hack a fix, but putting the 64-bit libraries in the directory where the 32-bit ones should be. As such, this change is worth having, even though it is not a complete cure.

Dave

comment:7 Changed 3 years ago by was

  • Status changed from needs_review to closed
  • Resolution set to wontfix
  • Milestone changed from sage-4.5 to sage-4.4.4

ghmm is now gone.

comment:8 Changed 3 years ago by was

  • Merged in set to 4.4.4.rc0

comment:9 Changed 3 years ago by mvngu

  • Milestone changed from sage-4.4.4 to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.