Ticket #9008 (closed defect: fixed)
Update zlib to latest upstream, and clean up spkg-install
|Reported by:||drkirkby||Owned by:||drkirkby|
|Report Upstream:||N/A||Reviewers:||Mike Hansen, Jaap Spies|
|Authors:||David Kirkby, Mike Hansen||Merged in:||sage-4.5.alpha0|
Description (last modified by drkirkby) (diff)
The zlib package building 32-bit on OpenSolaris (see #7128), and has various hacks to make it build 64-bit on OS X. The spkg-install has various hacks, which I think are better implemented other ways.
seems better replaced by the command line option available on the configure script.
is not currently the correct way to make a 64-bit build - the option
is for that purpose. The developer (Mark Alder) was surprised hacks were needed for OS X, as that is his main development platform.
3) The spkg-install adds
which apparently is(was) needed on Debian on Opteron. It would seem more sensible to add that option just on that platform if it is a problem specific to that platform.
This package is much cleaner, but may not work on all platforms. It would be better to make the code cleaner, and fix what (if any) issues do actually still exist.
comment:12 Changed 3 years ago by jsp
- Status changed from needs_review to positive_review
- Reviewers changed from Mike Hansen to Mike Hansen, Jaap Spies
- Authors changed from David Kirkby to David Kirkby, Mike Hansen