Ticket #8754 (needs_work enhancement)

Opened 3 years ago

Last modified 3 years ago

sagenb -- add "how to test" directions to the sagenb README.txt

Reported by: was Owned by: jason, was
Priority: minor Milestone: sage-5.10
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: William Stein
Authors: William Stein, Alex Leone Merged in:
Dependencies: Stopgaps:

Description

1. Doctest: 
       sage -t -sagenb 
2. Run the Selenium test suite:
       sage -python sagenb/testing/run_tests.py 

To use Selenium, you must visit http://seleniumhq.org/download/ and:

      * Download and extract Selenium RC ("the Selenium Remote Control")

      * Run it as follows on Linux:
             $ cd /path/to/selenium-remote-control-1.0.3/selenium-server-1.0.3
             $ java -jar selenium-server.jar
             $ cd /path/to/sagenb-0.8/src/sagenb
             $ sage  -python sagenb/testing/run_tests.py

      * Run it as follows on OS X:
             $ cd /path/to/selenium-remote-control-1.0.3/selenium-server-1.0.3
             $ cd /path/to/sagenb-0.8/src/sagenb
             $ sage
             sage: import sagenb.testing.run_tests as rt 
             sage: rt.setup_tests('localhost', False, '*firefox')
             sage: rt.run_any()

That the instructions for OS X are different is probably a bug.

Attachments

trac_8754-sagenb.patch Download (1.2 KB) - added by was 3 years ago.
trac_8754-sagenb.2.patch Download (2.5 KB) - added by acleone 3 years ago.
Added a development section. Replaces the last patch
trac_8754-sagenb.replaces2.patch Download (3.3 KB) - added by acleone 3 years ago.
Newest Version. Added a "Reviewing Patches" section. Apply only this.

Change History

Changed 3 years ago by was

comment:1 Changed 3 years ago by was

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by was

  • Status changed from needs_review to positive_review

Changed 3 years ago by acleone

Added a development section. Replaces the last patch

comment:3 Changed 3 years ago by acleone

  • Reviewers set to William Stein
  • Authors set to William Stein, Alex Leone

Changed 3 years ago by acleone

Newest Version. Added a "Reviewing Patches" section. Apply only this.

comment:4 Changed 3 years ago by mpatel

  • Status changed from positive_review to needs_work

Should someone review the latest patch? I noticed two minor problems:

  • dwnload
  • An extra * in b) * Run it as follows:

Also, should the reviewing section first refer in some way to steps 1,2,3, and/or 6 of the development section?

Note: See TracTickets for help on using tickets.