Ticket #8740 (needs_review enhancement)

Opened 3 years ago

Last modified 12 months ago

Upgrade sqlalchemy to 0.7.6

Reported by: timdumol Owned by: tbd
Priority: major Milestone: sage-5.10
Component: packages: standard Keywords:
Cc: tdumol, fbissey Work issues: SPKG.txt
Report Upstream: N/A Reviewers: François Bissey
Authors: Mike Hansen, Tim Dumol Merged in:
Dependencies: Stopgaps:

Description (last modified by mhansen) (diff)

The latest version of SQLAlchemy is now 0.7.6. This brings a bunch of changes, notably a native unicode mode, which would be a lot faster for unicode rich applications, such as the Sage Notebook.

The new package is at  http://sage.math.washington.edu/home/mhansen/sqlalchemy-0.7.6.spkg

Change History

comment:1 Changed 3 years ago by timdumol

  • Status changed from new to needs_review
  • Description modified (diff)
  • Authors set to Tim Dumol

comment:2 Changed 3 years ago by mhansen

  • Cc tdumol added
  • Description modified (diff)
  • Authors changed from Tim Dumol to Mike Hansen

comment:3 Changed 2 years ago by fbissey

  • Cc fbissey added

comment:4 Changed 2 years ago by fbissey

Now at 0.6.7 anyone wants to make a new spkg?

comment:5 follow-up: ↓ 6 Changed 2 years ago by timdumol

Actually, sqlalchemy now has a release  http://www.sqlalchemy.org/download.html|0.7, and since nothing in Sage currently uses it (at least, in the standard packages), it may be best to upgrade to 0.7. What do you think?

comment:6 in reply to: ↑ 5 Changed 2 years ago by fbissey

Replying to timdumol:

Actually, sqlalchemy now has a release  http://www.sqlalchemy.org/download.html|0.7, and since nothing in Sage currently uses it (at least, in the standard packages), it may be best to upgrade to 0.7. What do you think?

No objections, I seem to be in a reviewing mood. If you post it, I'll test it on a couple of systems.

comment:7 Changed 2 years ago by timdumol

  • Status changed from needs_review to needs_work
  • Description modified (diff)
  • Summary changed from Upgrade sqlalchemy to 0.6.0 to Upgrade sqlalchemy to 0.7.0

Alright. Package made, but it's taking a bit of time to upload to server.

comment:8 Changed 2 years ago by timdumol

  • Status changed from needs_work to needs_review
  • Description modified (diff)
  • Authors changed from Mike Hansen to Mike Hansen, Tim Dumol

comment:9 Changed 2 years ago by fbissey

everything is ok on x86 and amd64. I am testing this on OSX and then I'll give it a positive review.

comment:10 Changed 2 years ago by fbissey

  • Status changed from needs_review to positive_review
  • Reviewers set to François Bissey

Fine on OS X. No doctests to run or break and there is currently no SPKG check but that should be another ticket provided that sqlalchemy has some self-tests. Positive review from me.

comment:11 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to needs_work
  • Work issues set to SPKG.txt

SPKG.txt should mention version number 0.7.0 instead of 0.7. It would also be good to mention the ticket number in SPKG.txt

comment:12 Changed 2 years ago by jdemeyer

Note that in the mean time, SQLAlchemy 0.7.1 was released ( http://www.sqlalchemy.org/download.html), maybe you might as well use that version?

comment:13 Changed 2 years ago by jdemeyer

*ping*

comment:14 Changed 2 years ago by fbissey

Sorry Jeroen, I have been busy with a couple of earthquakes and I was hoping Tim would make the new spkg.

comment:15 Changed 14 months ago by mhansen

  • Status changed from needs_work to needs_review
  • Description modified (diff)

I've updated the spkg to 0.7.6.

Last edited 14 months ago by mhansen (previous) (diff)

comment:16 Changed 12 months ago by mhansen

  • Summary changed from Upgrade sqlalchemy to 0.7.0 to Upgrade sqlalchemy to 0.7.6
Note: See TracTickets for help on using tickets.