Ticket #8576 (closed enhancement: fixed)

Opened 6 months ago

Last modified 5 months ago

Categories for QQ, CC, RR and friends

Reported by: nthiery Owned by: AlexGhitza
Priority: major Milestone: sage-4.4
Component: algebra Keywords: categories, real fields
Cc: sage-combinat Author(s): Nicolas M. Thiéry
Report Upstream: N/A Reviewer(s): John Cremona
Merged in: sage-4.4.alpha0 Work issues:

Description

After this patch, QQ,ZZ,... inherit properly from categories: 

sage: QQ.category()
Category of fields
sage: TestSuite(QQ).run()

This patch also documents the following effect discovered by TestSuite?: 

    sage: CDF = ComplexDoubleField()
    sage: x = CDF.an_element()
    sage: x
    1.0*I
    sage: x*x, x**2, x*x == x**2
    (-1.0, -1.0 + 1.22460635382e-16*I, False)

This effect won't be touched by this patch. Should anyone consider this as a bug, please open a new ticket.

Attachments

trac_8576-category-QQ-RR-CC-nt.patch Download (8.4 KB) - added by nthiery 6 months ago.

Change History

Changed 6 months ago by nthiery

Changed 6 months ago by nthiery

  • status changed from new to needs_review

All test passed for me.

Changed 5 months ago by cremona

  • status changed from needs_review to positive_review

Applies fine to 4.3.5 and all tests pass.

Changed 5 months ago by nthiery

  • reviewer set to John Cremona

Thanks for the review!

Changed 5 months ago by jhpalmieri

  • status changed from positive_review to closed
  • resolution set to fixed
  • merged set to sage-4.4.alpha0

Merged "trac_8576-category-QQ-RR-CC-nt.patch" in 4.4.alpha0

Note: See TracTickets for help on using tickets.