Ticket #8536 (closed defect: fixed)
Change SAGE" to "Sage" in output
| Reported by: | cremona | Owned by: | was |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.4 |
| Component: | user interface | Keywords: | |
| Cc: | jhpalmieri | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Dan Drake |
| Authors: | John Cremona | Merged in: | sage-4.4.alpha0 |
| Dependencies: | Stopgaps: |
Description
When quitting we see
Exiting SAGE (CPU time 0m0.04s, Wall time 0m0.63s).
and there are several other places where "SAGE" is output instead of "Sage".
The patch changes these. I tested the whole library: no doctests needed changing at all. But maybe there are other issues which I did not think of.
Attachments
-
trac_8536-SAGE.patch
(7.5 KB) -
added by cremona 3 years ago.
- applies to 4.3.5
-
trac_8536-SAGE.2.patch
(9.3 KB) -
added by cremona 3 years ago.
- same as previous + c_lib/src/interrupt.c edits
Change History
comment:2 Changed 3 years ago by ddrake
- Status changed from needs_review to needs_work
This looks good, although I did find some other instances of SAGE in output: c_lib/src/interrupt.c near the end of the file has a bunch of SAGEs; see line 138 to the end. With those changes, I'll give this a positive review.
comment:3 follow-up: ↓ 5 Changed 3 years ago by cremona
I don't know how to change the file c_lib/src/interrupt.c safely since it is not included in the cloning system. Can you either tell me how to do that, or do it yourself?
Meanwhile I have added to the patch to deal with file misc/sagedoc.py so that the latex control sequences \sage and \SAGE (and also \Sage) convert to 'Sage' instead of 'SAGE'. I am not too sure of the reperucssions of this (it will surely change a lot o the documentation, but not affect doctests), so I am cc-ing jpalmieri and hope that he will comment.
I testing the whole sage library and all tests passed.
comment:5 in reply to: ↑ 3 Changed 3 years ago by ddrake
Replying to cremona:
I don't know how to change the file c_lib/src/interrupt.c safely since it is not included in the cloning system. Can you either tell me how to do that, or do it yourself?
I believe that directory is in the same Mercurial repo that the main Sage library is in -- it looks like interrupt.c was last changed by revision 9552:470b9bd4c96e (try "hg annotate" on that file). If you are using queues, you should be able to just make the change and do "hg qref". That worked for me.
I'm running doctests now; it's not finished, but I would be surprised if anything fails.
Changed 3 years ago by cremona
-
attachment
trac_8536-SAGE.2.patch
added
same as previous + c_lib/src/interrupt.c edits
comment:6 Changed 3 years ago by cremona
- Status changed from needs_work to needs_review
You are right. I updated the patch to include that file, and reinstated "needs review".
comment:7 Changed 3 years ago by ddrake
- Status changed from needs_review to positive_review
- Reviewers set to Dan Drake
Everything looks good, and all tests pass. Positive review -- although if John Palmieri finds something fishy with the sagedoc.py, he should revert that. I find it very unlikely that there's any problem, though.
comment:8 follow-up: ↓ 9 Changed 3 years ago by jhpalmieri
- Cc jhpalmieri added; jpalmieri removed
The changes to sagedoc.py look okay to me.
comment:9 in reply to: ↑ 8 Changed 3 years ago by cremona
Replying to jhpalmieri:
The changes to sagedoc.py look okay to me.
Thanks, and sorry for the typo. John
comment:11 Changed 3 years ago by jhpalmieri
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.4.alpha0
Merged "trac_8536-SAGE.2.patch" in 4.4.alpha0.
