Ticket #8394 (closed defect: fixed)
plot/plot3d/tri_plot.py is at 0% coverage: get it to 100%
| Reported by: | mhampton | Owned by: | was |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.4.1 |
| Component: | graphics | Keywords: | doctests, coverage, plotting |
| Cc: | wcauchois, boothby | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Minh Van Nguyen, Tom Boothby |
| Authors: | Marshall Hampton | Merged in: | sage-4.4.1.alpha2 |
| Dependencies: | Stopgaps: |
Description
The adaptive refinement code in tri_plot.py has almost no docstrings or tests. However, there are a lot of helpful comments in the code, and the file is not very long, so it should be pretty easy to bring this up to 100% coverage.
Attachments
-
trac_8394_v1.patch
(13.9 KB) -
added by mhampton 3 years ago.
- adds basic doctests to tri_plot.py
-
trac_8394-reviewer.patch
(851 bytes) -
added by mvngu 3 years ago.
Change History
Changed 3 years ago by mhampton
-
attachment
trac_8394_v1.patch
added
comment:2 Changed 3 years ago by mhampton
- Cc wcauchois, boothby added
The patch formally gets coverage of tri_plot.py from 0 to 100%. Since I still don't completely understand this module, the tests and descriptions could be better but this is an improvement.
comment:3 Changed 3 years ago by mvngu
- Reviewers set to Minh Van Nguyen
- Authors changed from mhampton to Marshall Hampton
The documentation is OK by me. I have just one trivial patch to add, which requires another pair of eyes other than mine. So if that reviewer patch gets a positive review, the whole ticket is good to go.
When the module plot/plot3d/tri_plot.py is added to the reference manual, building the reference manual with that newly added module would result in some warnings. But fixing that is another ticket.
comment:4 Changed 3 years ago by boothby
- Status changed from needs_review to positive_review
- Reviewers changed from Minh Van Nguyen to Minh Van Nguyen, Tom Boothby
Looks great! Thank you!
adds basic doctests to tri_plot.py