Ticket #8363 (closed defect: fixed)
cddlib-094f.p4 has a useless check for mpir which breaks on Solaris
|Reported by:||drkirkby||Owned by:||drkirkby|
|Report Upstream:||N/A||Reviewers:||Jaap Spies, Minh Van Nguyen|
|Authors:||David Kirkby||Merged in:||sage-4.3.4.alpha0|
spkg/install/deps shows that cddlib depends on mpir
$(INST)/$(CDDLIB): $(BASE) $(INST)/$(MPIR) $(SAGE_SPKG) $(CDDLIB) 2>&1
but for some reason someone has added a check in cddlib's spkg-install. This seems a bit pointless, but is causing a breakage on Solaris
# We depend on mpir, make sure it is installed (GMP fork) MPIR_VERSION=`cd $SAGE_ROOT/spkg/standard/; ./newest_version mpir` if [ $? -ne 0 ]; then echo "Failed to find mpir. Please install the mpir spkg" exit 1 fi
They do not even export MPIR_VERSION, so it is a useless bit of code that is breaking on Solaris.
Also, currently cddlib will not build on 64-bit Solaris, due to the normal check that the platform is OS X:
if [ `uname` = "Darwin" ] && [ "$SAGE64" = "yes" ]; then echo "64 bit MacIntel" CFLAGS="$CFLAGS -m64 "; export CFLAGS fi
Both these issues are easily resolved. A patch and updated .spkg will follow shortly.
- Status changed from needs_review to positive_review
- Reviewers set to Jaap Spies, Minh Van Nguyen