Ticket #8253 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

search_src (etc.) bug

Reported by: jhpalmieri Owned by: tbd
Priority: major Milestone: sage-4.3.3
Component: misc Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Mitesh Patel
Authors: John Palmieri Merged in: sage-4.3.3.alpha1
Dependencies: Stopgaps:

Description

In Sage 4.3.2: 

search_src('is', 'prime', 'field', ignore_case=True)
Traceback (most recent call last):
...
TypeError: search() takes at most 3 arguments (4 given)

This is because of a bug in sage.misc.sagedoc: when calling re.search, flags like re.MULTILINE and re.IGNORECASE should be combined using bit-wise or, not by passing them as separate entries in a list. The attached patch fixes this.

Attachments

trac_8253-search.patch Download (1.9 KB) - added by jhpalmieri 3 years ago.
trac_8253-search.v2.patch Download (2.4 KB) - added by jhpalmieri 3 years ago.

Change History

Changed 3 years ago by jhpalmieri

comment:1 Changed 3 years ago by mpatel

I noticed another *flags nearby. Should we make it flags?

comment:2 Changed 3 years ago by jhpalmieri

  • Status changed from new to needs_review

Yes. Here's a new patch, rebased against 4.3.3.alpha0.

Changed 3 years ago by jhpalmieri

comment:3 Changed 3 years ago by mpatel

  • Status changed from needs_review to positive_review
  • Reviewers set to Mitesh Patel

comment:4 Changed 3 years ago by mvngu

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.3.3.alpha1

Merged  trac_8253-search.v2.patch.

Note: See TracTickets for help on using tickets.