Ticket #8147 (closed enhancement: fixed)

Opened 7 weeks ago

Last modified 6 weeks ago

Add mercurial queues information to Developer Walkthrough

Reported by: rbeezer Owned by: mvngu
Priority: minor Milestone: sage-4.3.2
Component: documentation Keywords:
Cc: mvngu, rossk, jpalmieri, leif Author(s): Rob Beezer
Report Upstream: N/A Reviewer(s): Minh Van Nguyen, Rob Beezer
Merged in: sage-4.3.2.rc0 Work issues:

Description

This is a follow-on to #8108 expanding on basic use of Mercurial queues for Sage development.

Attachments

trac_8147_developer_doc_mq.patch Download (13.8 KB) - added by rbeezer 7 weeks ago.
trac_8147-reviewer.patch Download (13.0 KB) - added by mvngu 7 weeks ago.
apply on top of previous

Change History

Changed 7 weeks ago by rbeezer

  Changed 7 weeks ago by rbeezer

  • status changed from new to needs_review

Apply #8108 prior to applying this patch.

  Changed 7 weeks ago by rbeezer

  • cc jpalmieri added
  • author set to Rob Beezer

  Changed 7 weeks ago by leif

  • cc leif added

Changed 7 weeks ago by mvngu

apply on top of previous

follow-up: ↓ 5   Changed 7 weeks ago by mvngu

  • reviewer set to Minh Van Nguyen

The attachment  trac_8147_developer_doc_mq.patch is a valuable addition to the Developers' Guide. It's what many people have been asking for months now. I'm happy with the content. Obviously, there are not enough patches on this ticket, so I have attached a reviewer patch :-) Only the attachment  trac_8147-reviewer.patch needs review.

in reply to: ↑ 4   Changed 6 weeks ago by rbeezer

  • status changed from needs_review to positive_review

Replying to mvngu:

Thanks, Minh - those are some good additions, and I've learned a couple more fine-points. And, as always, thanks for cleaning up my grammar. ;-)

The reviewer patch looks good to me, thankfully I had a guide to show me how to apply it. I think I'm allowed to give such a thing a review, and if so, it's a positive review.

So it sounds like this is ready to go, and I'll mark it "positive review" - change it back if I missed something procedurally.

That was a nice collaboration - thanks for prodding me into action.

Rob

  Changed 6 weeks ago by mvngu

  • status changed from positive_review to closed
  • reviewer changed from Minh Van Nguyen to Minh Van Nguyen, Rob Beezer
  • resolution set to fixed
  • merged set to sage-4.3.2.rc0

Merged in this order:

  1.  trac_8147_developer_doc_mq.patch
  2.  trac_8147-reviewer.patch
Note: See TracTickets for help on using tickets.