Ticket #8020 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

python-2.6.4.p4 spkg *totally breaks* itanium support

Reported by: was Owned by: tbd
Priority: blocker Milestone: sage-4.3.2
Component: packages: standard Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Craig Citro
Authors: William Stein Merged in: sage-4.3.2.alpha0
Dependencies: Stopgaps:

Description

gcc version 4.4.2 (GCC)
****************************************************
Updating readline.c for Linux/Itanium
cp: cannot create regular file `Modules/readline.c': No such file or directory
Error copying patched readline.c

real    0m0.029s
user    0m0.009s
sys     0m0.011s
sage: An error occurred while installing python-2.6.4.p4
Please email sage-devel http://groups.google.com/group/sage-devel
explaining the problem and send the relevant part of
of /home/wstein/screen/cleo/sage-4.3.1/install.log.  Describe your c

I missed this doing the release, because our Itaniums weren't accessible.

Change History

comment:1 Changed 3 years ago by was

This appears to be trivial to fix. In spkg-install change:

# The following patch for fixing broken readline behavior on Itanium
# Linux definitely does *not* work on anything else.
if [ "`uname -m`" = "ia64" -a "`uname`" = "Linux" ]; then
    echo "Updating readline.c for Linux/Itanium"
    cp patches/readline.c-Itanium-fix Modules/readline.c

to

# The following patch for fixing broken readline behavior on Itanium
# Linux definitely does *not* work on anything else.
if [ "`uname -m`" = "ia64" -a "`uname`" = "Linux" ]; then
    echo "Updating readline.c for Linux/Itanium"
    cp patches/readline.c-Itanium-fix src/Modules/readline.c

comment:2 Changed 3 years ago by was

  • Status changed from new to needs_review

comment:3 Changed 3 years ago by craigcitro

  • Status changed from needs_review to positive_review

Oops ... yep, that was totally a typo on my part while moving things around in the file. Sorry about that ... fix is obviously the right one.

comment:4 Changed 3 years ago by mvngu

  • Status changed from positive_review to closed
  • Reviewers set to Craig Citro
  • Resolution set to fixed
  • Merged in set to sage-4.3.2.alpha0
  • Authors set to William Stein

William's commit message references ticket #8080, which at present doesn't exist. I've changed the ticket number in his commit message to #8020. For reference, my change (to William's commit message) can be found at

 http://sage.math.washington.edu/home/mvngu/spkg/standard/python/python-2.6.4.p5.spkg

Merged  python-2.6.4.p5.spkg in the standard spkg repository.

Note: See TracTickets for help on using tickets.