Ticket #800 (closed enhancement: duplicate)

Opened 6 years ago

Last modified 2 years ago

make _sig_on and _sig_off faster when stacked

Reported by: craigcitro Owned by: malb
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: interfaces Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Mariah Lenox
Authors: Merged in:
Dependencies: Stopgaps:

Description

Gonzalo brought up the following very good idea: one should rewrite the code for _sig_on and _sig_off to keep a counter of how many _sig_on calls it has seen, and run less than the full amount of code (i.e. nothing involving system calls) if we've already had a _sig_on. Then _sig_off can just decrement the counter, and only do the "real work" if it's being decremented to zero.

Change History

comment:1 Changed 6 years ago by was

  • Milestone changed from sage-2.8.6 to sage-2.9

comment:2 Changed 4 years ago by malb

  • Type changed from defect to enhancement

comment:3 Changed 4 years ago by malb

  • Owner changed from tornaria to malb
  • Status changed from new to assigned

comment:4 Changed 3 years ago by jdemeyer

  • Report Upstream set to N/A

This should be implemented as part of #9678.

comment:5 Changed 2 years ago by jdemeyer

  • Status changed from new to needs_review
  • Milestone changed from sage-4.6.2 to sage-duplicate/invalid/wontfix

Fixed by #9678.

comment:6 Changed 2 years ago by mariah

  • Status changed from needs_review to positive_review
  • Reviewers set to Mariah Lenox

If this is a sage-duplicate/invalid/wontfix, then I believe this ticket can be closed.

comment:7 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to duplicate
Note: See TracTickets for help on using tickets.