Ticket #7985 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

fix doctest in base.pyx

Reported by: wcauchois Owned by: was
Priority: major Milestone: sage-4.3.1
Component: graphics Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Willem Jan Palenstijn
Authors: Bill Cauchois Merged in: sage-4.3.1.rc1
Dependencies: Stopgaps:

Description

The following doctest from line 757 of base.pyx: 

sage: G = tetrahedron(color='red') + tetrahedron(color='yellow') + tetrahedron(color='red', opacity=0.5)
sage: G.texture_set()
set([Texture(texture..., red, ff0000), Texture(texture..., yellow, ffff00), Texture(texture..., red, ff0000)])

will fail sometimes because the order of the elements of the set is not fixed. The attached patch fixes this by outputting first the two red textures, and then the yellow texture.

Attachments

fix-annoying-doctest.patch Download (1.1 KB) - added by wcauchois 3 years ago.
based on sage 4.3.1.rc0

Change History

Changed 3 years ago by wcauchois

based on sage 4.3.1.rc0

comment:1 Changed 3 years ago by wjp

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by wjp

  • Status changed from needs_review to positive_review

Looks good.

comment:3 Changed 3 years ago by rlm

  • Status changed from positive_review to closed
  • Reviewers set to Willem Jan Palenstijn
  • Resolution set to fixed
  • Merged in set to sage-4.3.1.rc1
Note: See TracTickets for help on using tickets.