Ticket #7880 (closed enhancement: fixed)
Category of sets with partial maps.
| Reported by: | robertwb | Owned by: | nthiery |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.4 |
| Component: | categories | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Robert Bradshaw, David Loeffler |
| Authors: | David Roe | Merged in: | sage-4.4.alpha0 |
| Dependencies: | Stopgaps: |
Description
In support of #7585 and Tate's algorithm over function fields.
Attachments
-
7585_4_sets_with_partial_maps.patch
(13.8 KB) -
added by robertwb 3 years ago.
-
trac_7880-sets_with_partial_maps.patch
(14.0 KB) -
added by davidloeffler 3 years ago.
- replaces previous patch
Change History
comment:2 Changed 3 years ago by robertwb
- Status changed from needs_review to positive_review
Looks good.
comment:3 Changed 3 years ago by nthiery
- Status changed from positive_review to needs_work
I am not convinced about the name, which suggests at first that the objects are Sets with more structure, not less. I don't have a better suggestion though. If nobody comes up with something better (ObjectsWith????) in a day or two, just put back a positive review.
comment:5 Changed 3 years ago by roed
- Status changed from needs_info to needs_review
- Milestone changed from sage-4.3.4 to sage-4.3.3
This is needed for the series of patches starting at 8218. I agree that the name is not optimal, but nobody's come up with a better one in 6 weeks...
comment:7 Changed 3 years ago by roed
Part of a series:
8218 -> 8332 -> 7880 -> 7883 -> 8333 -> 8334 -> 8335
I tried to make each of these mostly self contained, with doctests passing after every ticket, but I didn't entirely succeed. If you're reviewing one of these tickets, applying later tickets will hopefully fix doctest failures that you're seeing.
Changed 3 years ago by davidloeffler
-
attachment
trac_7880-sets_with_partial_maps.patch
added
replaces previous patch
comment:8 Changed 3 years ago by davidloeffler
- Status changed from needs_review to positive_review
- Reviewers changed from Robert Bradshaw to Robert Bradshaw, David Loeffler
Looks good to me. I've made some tiny doctest fixes, and uploaded a new version of the patch, still with roed's user stamp on it. This applies cleanly to 4.3.4.rc0, if you apply the patches in the following order:
$ sage -hg qseries trac_8218_fixes_434alpha1.patch trac_8332_givaro_python.patch trac_8332_reviewer.patch trac_7880-sets_with_partial_maps.patch
comment:9 Changed 3 years ago by nthiery
Oh, just one thing: are objects in SetsWithPartialMaps? parents or not?
comment:10 Changed 3 years ago by jhpalmieri
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.4.alpha0
Merged "trac_7880-sets_with_partial_maps.patch" in 4.4.alpha0
