Ticket #7777 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Implement SymmetricFunctions(QQ).inject_shorthands()

Reported by: nthiery Owned by: sage-combinat
Priority: major Milestone: sage-4.3.1
Component: combinatorics Keywords: symmetric functions, inject
Cc: sage-combinat, jbandlow Author(s): Nicolas M. Thiéry
Report Upstream: N/A Reviewer(s): Jason Bandlow
Merged in: sage-4.3.1.rc0 Work issues:

Description

The title says it all. Depends on #7776

Attachments

Change History

  Changed 8 months ago by nthiery

  • status changed from new to needs_review

Beware: patch written and tested on Sage 4.2, not 4.3.

  Changed 8 months ago by jbandlow

  • cc jbandlow added

Although I haven't tested it yet, I'm in principle very happy with the 'green' part of the patch. Could you say a little about the 'red' part? What's being deleted from the 'introspect' files and why?

Changed 8 months ago by nthiery

  Changed 8 months ago by jbandlow

  • status changed from needs_review to positive_review

Looks good to me (on top of 7776). Thanks for this, Nicolas!

follow-up: ↓ 5   Changed 8 months ago by rlm

  • status changed from positive_review to needs_work 
The following tests failed:

        sage -t -long devel/sage-main/sage/combinat/sf/sf.py # 10 doctests failed

in reply to: ↑ 4   Changed 8 months ago by nthiery

Replying to rlm:

{{{ The following tests failed: sage -t -long devel/sage-main/sage/combinat/sf/sf.py # 10 doctests failed }}}

Thanks for the report. I did not manage yet to reproduce yet (I am downloading 4.3.1.alpha). Could you send me a copy of the log? Was 7776 applied?

Cheers

follow-up: ↓ 8   Changed 8 months ago by rlm

  • status changed from needs_work to needs_review

I had gotten too sleepy! Sorry, I didn't notice the dependency (it is 4am here now)...

  Changed 8 months ago by rlm

  • status changed from needs_review to positive_review

in reply to: ↑ 6   Changed 8 months ago by nthiery

Replying to rlm:

I had gotten too sleepy! Sorry, I didn't notice the dependency (it is 4am here now)...

:-)

We really should be using a ticket dependency plugin like:  http://trac-hacks.org/wiki/MasterTicketsPlugin.

Have a good night!

  Changed 8 months ago by rlm

  • status changed from positive_review to closed
  • reviewer set to Jason Bandlow
  • resolution set to fixed
  • merged set to sage-4.3.1.rc0
Note: See TracTickets for help on using tickets.