Ticket #7524 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

frame axes are lost when saving a graphic to a file

Reported by: jason Owned by: was
Priority: major Milestone: sage-4.6.2
Component: graphics Keywords:
Cc: novoselt, jason Work issues:
Report Upstream: N/A Reviewers: Andrey Novoseltsev
Authors: Karl-Dieter Crisman Merged in: sage-4.6.2.alpha3
Dependencies: Stopgaps:

Description

Notice that the frame axes are shown when using "show", but are missing when using "save" 

----------------------------------------------------------------------
| Sage Version 4.2.1, Release Date: 2009-11-14                       |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: var('x,y')                
(x, y)
sage: a=plot_vector_field((x,-y),(x,-1,1),(y,-1,1))
sage: a.show()
sage: a.save('test.png')

Attachments

trac_7524-options-save.patch Download (1.0 KB) - added by kcrisman 2 years ago.

Change History

comment:1 Changed 3 years ago by jason

  • Status changed from new to needs_review

This is fixed with #7981

comment:2 Changed 3 years ago by rossk

  • Status changed from needs_review to needs_work

Got the following on applying trac-7981-show_options.patch to sage-4.3.2-alpha

~/sage-4.3.2.alpha0/devel/sage-main$ hg qpush applying trac-7981-show_options.patch patching file sage/plot/plot.py Hunk #3 FAILED at 1913 1 out of 5 hunks FAILED -- saving rejects to file sage/plot/plot.py.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh trac-7981-show_options.patch

comment:3 Changed 2 years ago by kcrisman

  • Work issues set to check works, document with patch

Might be worth trying this again, now that #7981 has positive review. Would need a patch to document.

comment:4 Changed 2 years ago by kcrisman

I can confirm that this works after #7981.

comment:5 Changed 2 years ago by kcrisman

  • Work issues check works, document with patch deleted

This test checks that it works. Passes relevant test, plot looks good.

Changed 2 years ago by kcrisman

comment:6 Changed 2 years ago by kcrisman

  • Cc novoselt, jason added
  • Status changed from needs_work to needs_review
  • Authors set to Karl-Dieter Crisman

This definitely depends on #7981, #8632, and #10244. It's conceivable, but unlikely, that it depends on #10143, and might also depend on #2100. All in that order. This is because it applies to the very popular file plot.py.

comment:7 Changed 2 years ago by novoselt

  • Status changed from needs_review to positive_review
  • Reviewers set to Andrey Novoseltsev

Let's say it depends on #10143, since it has positive review already. The patch looks and applies fine, positive review!

comment:8 Changed 2 years ago by kcrisman

I've set #2100 to 'needs work', but this still applies fine after #7981, #8632, #10244, and #10143 on 4.6.2.alpha1, so still should be included in the next alpha.

comment:9 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.6.2.alpha3
Note: See TracTickets for help on using tickets.