Ticket #7425 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

I.variety() doesn't check that I is zero-dimensional

Reported by: AlexGhitza Owned by: malb
Priority: major Milestone: sage-4.2.1
Component: commutative algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Martin Albrecht
Authors: Alex Ghitza Merged in: sage-4.2.1.rc0
Dependencies: Stopgaps:

Description

I.variety() should first check whether the ideal I is indeed 0-dimensional and refuse to continue otherwise. This should be a fairly trivial fix. Right now the following seems to run forever: 

----------------------------------------------------------------------
| Sage Version 4.2, Release Date: 2009-10-24                         |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: R.<x, y, z> = QQ[]
sage: I = R.ideal([x^2-y^3*z, x+y*z])
sage: I.dimension()
1
sage: I.variety()
verbose 0 (1808: multi_polynomial_ideal.py, variety) Warning: falling back to very slow toy implementation.

Attachments

trac_7425.patch Download (2.5 KB) - added by AlexGhitza 4 years ago.

Change History

Changed 4 years ago by AlexGhitza

comment:1 Changed 4 years ago by AlexGhitza

  • Status changed from new to needs_review
  • Authors set to Alex Ghitza

comment:2 Changed 4 years ago by malb

  • Status changed from needs_review to positive_review

patch looks good, applies cleanly against 4.2, doctests pass, reference manual builds without any warnings.

comment:3 Changed 4 years ago by mhansen

  • Status changed from positive_review to closed
  • Reviewers set to Martin Albrecht
  • Resolution set to fixed
  • Merged in set to sage-4.2.1.rc0

comment:4 Changed 4 years ago by mhansen

  • Milestone changed from sage-4.3 to sage-4.2.1
Note: See TracTickets for help on using tickets.