Ticket #724 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[with patch] graph6 parsing does not throw an error when the string is the wrong size.

Reported by: jason Owned by: rlm
Priority: major Milestone: sage-2.8.10
Component: combinatorics Keywords: graph6, graph
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

Making a graph from a graph6 string should check to make sure the string is the right size and throw an error if the string is too long or too short. I believe now it just silently hands back a graph that is not correct.

This is bad, especially when your string has an escaped character and you didn't realize it :).

Attachments

7087.patch Download (1.6 KB) - added by rlm 3 years ago.
7148.patch Download (2.2 KB) - added by rlm 3 years ago.

Change History

Changed 3 years ago by mabshoff

  • milestone set to sage-2.9

Changed 3 years ago by rlm

Changed 3 years ago by rlm

  • owner changed from was to rlm
  • status changed from new to assigned
  • summary changed from graph6 parsing does not throw an error when the string is the wrong size. to [with patch] graph6 parsing does not throw an error when the string is the wrong size.

Changed 3 years ago by rlm

  • milestone changed from sage-2.9 to sage-2.8.10

Changed 3 years ago by rlm

This patches cleanly onto 2.8.9.

Changed 3 years ago by cwitty

Please add doctests to show the new exceptions. (Every bug fix should have a doctest.)

Thanks!

Changed 3 years ago by rlm

Changed 3 years ago by cwitty

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.