Ticket #7208 (closed enhancement: fixed)

Opened 11 months ago

Last modified 10 months ago

Refactorisation of families

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: combinatorics Keywords: Family, enumerated set
Cc: sage-combinat Author(s): Florent Hivert
Report Upstream: Reviewer(s): Nicolas M. Thiéry
Merged in: sage-4.3.alpha0 Work issues:

Description (last modified by nthiery) (diff)

Log of the attached patch:

Depends on #5891

Attachments

trac_7208_family_enumset.patch Download (41.4 KB) - added by nthiery 11 months ago.

Change History

Changed 11 months ago by nthiery

  • status changed from new to needs_review

Changed 11 months ago by nthiery

  • status changed from needs_review to positive_review

Changed 11 months ago by nthiery

  • description modified (diff)

Changed 11 months ago by nthiery

  • status changed from positive_review to needs_work

We should use the occasion to fix this bug:

sage: f = Family(["c", "a", "b"], lambda x: x+x) sage: list(f) ['aa', 'cc', 'bb']

Changed 11 months ago by nthiery

  • status changed from needs_work to needs_review

The updated patch is supposed to fix it. Florent: please review!

Changed 11 months ago by nthiery

  • description modified (diff)

Changed 11 months ago by nthiery

Changed 11 months ago by nthiery

Fixed missing doctests

Changed 11 months ago by hivert

  • status changed from needs_review to positive_review

Things are *now* ok :-) Positive review.

Florent

Changed 10 months ago by mhansen

  • status changed from positive_review to closed
  • resolution set to fixed
  • merged set to sage-4.3.alpha0
Note: See TracTickets for help on using tickets.