Ticket #717 (closed enhancement: fixed)

Opened 6 years ago

Last modified 5 years ago

[With patch, positive review] sage -t timeout stuff works poorly

Reported by: was Owned by: gfurnish
Priority: major Milestone: sage-3.2.2
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by mabshoff) (diff)

Issues:

  1. I can't actually find anywhere in sage-doctest right now where the two alarm codes are actually used, so SAGE should never timeout. Weird.
  2. It should be easy for users to adjust the timeout, e.g., on slow systems.

Attachments

trac_717_bin.patch Download (1.8 KB) - added by gfurnish 5 years ago.

Change History

comment:1 Changed 6 years ago by was

  • Milestone changed from sage-2.8.4.3 to sage-2.9

comment:2 Changed 6 years ago by mabshoff

  • Milestone changed from sage-2.10.1 to sage-2.9

This has annoyed me on regular occasions, so let's fix this.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Description modified (diff)

The third part of the ticket, i.e. 'sage --long" should automatically have a much longer timeout' is now now #2029.

Cheers,

Michael

comment:4 Changed 5 years ago by mabshoff

FYI, but this is probably orthogonal to the doctesting and more has to do with signal delivery.

Cheers,

Michael

Changed 5 years ago by gfurnish

comment:5 Changed 5 years ago by gfurnish

  • Owner changed from failure to gfurnish
  • Status changed from new to assigned
  • Summary changed from sage -t timeout stuff works poorly to [With patch, needs review] sage -t timeout stuff works poorly

This code enables timeouts.

comment:6 Changed 5 years ago by mabshoff

Patch looks with one tiny exception: 

[10:25pm] mab|ds9: one suggestions: raise the sleep period to 1 second: time.sleep(.1)
[10:25pm] gfurnish: feel free to make the modification
[10:25pm] mab|ds9: I think we can live with that.
[10:25pm] mab|ds9: mk

I will move item (2) to its own ticket since it is not addressed here.

Cheers,

Michael

comment:7 Changed 5 years ago by mabshoff

  • Summary changed from [With patch, needs review] sage -t timeout stuff works poorly to [With patch, positive review] sage -t timeout stuff works poorly

This works very nicely. Positive review.

(2) has been moved to #4712.

Cheers,

Michael

comment:8 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.2.2.alpha0

Note: See TracTickets for help on using tickets.