Ticket #7141 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] `math_parse` parses $'s in <script> tags

Reported by: timdumol Owned by: boothby
Priority: major Milestone: sage-4.2
Component: notebook Keywords: sagenb notebook jQuery
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Tim Dumol Merged in:
Dependencies: Stopgaps:

Description

sagenb.notebook.jsmath.math_parse (and the source, sage.misc.html.math_parse) parse $'s in <script> tags, which breaks jQuery code.

Attachments

trac_7141-sagenb-math_parse.patch Download (13.3 KB) - added by timdumol 4 years ago.
Fixes math_parse in sagenb.notebook.jsmath to skip <script> tags. Apply to sagenb repo.

Change History

Changed 4 years ago by timdumol

Fixes math_parse in sagenb.notebook.jsmath to skip <script> tags. Apply to sagenb repo.

comment:1 Changed 4 years ago by timdumol

  • Summary changed from `math_parse` parses $'s in <script> tags to [with patch, needs review] `math_parse` parses $'s in <script> tags

comment:2 Changed 4 years ago by was

  • Status changed from needs_review to closed
  • Resolution set to fixed
  • Summary changed from [with patch, needs review] `math_parse` parses $'s in <script> tags to [with patch, positive review] `math_parse` parses $'s in <script> tags

Very nice!

And I've applied it and pushed it to the official sagenb branch.

Note: See TracTickets for help on using tickets.