Ticket #7104 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Add config.py back to the reference manual.

Reported by: mpatel Owned by: tba
Priority: major Milestone: sage-4.2.1
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Adam Webb
Authors: Mitesh Patel Merged in:
Dependencies: Stopgaps:

Description

Ticket #6556 adds a much-needed, module-level docstring to sage/server/notebook/config.py. It should be in the Sage reference manual.

See  sage-devel.

Attachments

trac_7104-add_keys_to_ref_manual.patch Download (630 bytes) - added by mpatel 4 years ago.
Add the notebook key-bindings module to the reference manual. Apply to sage repository.

Change History

Changed 4 years ago by mpatel

Add the notebook key-bindings module to the reference manual. Apply to sage repository.

comment:1 Changed 4 years ago by mpatel

  • Priority changed from trivial to major

comment:2 Changed 4 years ago by mpatel

Oops. I think we need to account for all modules affected by the notebook separation (cf. #6983).

comment:3 Changed 4 years ago by awebb

  • Status changed from needs_review to positive_review
  • Reviewers set to Adam Webb
  • Summary changed from [with patch, needs review] Add config.py back to the reference manual. to [with patch, positive review] Add config.py back to the reference manual.

Works with sage -docbuild reference html. ~! Adam

comment:4 Changed 4 years ago by was

I'm confused. This is just adding to the reference manual pages about the old notebook code, which isn't even used anymore. I don't understand what the point is.

comment:5 Changed 4 years ago by was

(Of course, it can't really hurt for now, I guess, except to mislead people...)

comment:6 Changed 4 years ago by was

  • Component changed from documentation to notebook

I didn't realize this is old. It'll need to be rebased against  http://nb.sagemath.org/.

comment:7 follow-up: ↓ 8 Changed 4 years ago by was

  • Status changed from positive_review to needs_work

changing to needs work, since it needs to be rebased/redone.

comment:8 in reply to: ↑ 7 Changed 4 years ago by mpatel

Replying to was:

changing to needs work, since it needs to be rebased/redone.

Please see #7367.

comment:9 Changed 4 years ago by was

  • Status changed from needs_work to closed
  • Resolution set to fixed
  • Milestone changed from sage-4.3 to sage-4.2.1

This is fixed by #7367, so I'm closing this.

Note: See TracTickets for help on using tickets.