Ticket #7102 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] R.py doctest fails for non-english locale

Reported by: GeorgSWeber Owned by: GeorgSWeber
Priority: major Milestone: sage-4.1.2
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Georg S. Weber Merged in:
Dependencies: Stopgaps:

Description

Testing Sage-4.1.2-alpha4, I saw that the old failure from #6379 somehow was resurrected (probably by using some new version of the R package that has changed its internationalized warning messages). To reproduce the failure, do something (or nothing, see also #6379) like

export LANG=de_DE.UTF-8

from a (sage -sh) shell and then you'll get:

sage -t -long "devel/sage/sage/interfaces/r.py"             
**********************************************************************
File "/Users/Shared/sage/sage-4.1.2.alpha4/devel/sage/sage/interfaces/r.py", line 549:
    sage: r.library('foobar')
Expected:
    Traceback (most recent call last):
    ...
    ImportError: ...
Got nothing
**********************************************************************
File "/Users/Shared/sage/sage-4.1.2.alpha4/devel/sage/sage/interfaces/r.py", line 839:
    sage: r.completions('tes')
Expected:
    ['testInheritedMethods', 'testPlatformEquivalence', 'testVirtual']
Got:
    ['testInheritedMethods', 'testInheritedMethods', 'testPlatformEquivalence', 'testPlatformEquivalence', 'testVirtual', 'testVirtual']
**********************************************************************
2 items had failures:
   1 of   5 in __main__.example_17
   1 of   4 in __main__.example_34
***Test Failed*** 2 failures.
For whitespace errors, see the file /Users/georgweber/.sage//tmp/.doctest_r.py
         [7.3 s]
exit code: 1024
 
----------------------------------------------------------------------
The following tests failed:


        sage -t -long "devel/sage/sage/interfaces/r.py"

Fortunately, I fiddled around with this file and this bug more than once (see also #6594, #6646), so I knew where to look. Hopefully, this zombie is put down to rest ...

Attachments

trac_7102_doctest.patch Download (1.1 KB) - added by GeorgSWeber 4 years ago.
tested against 4.1.2.alpha4

Change History

Changed 4 years ago by GeorgSWeber

tested against 4.1.2.alpha4

comment:1 Changed 4 years ago by GeorgSWeber

  • Owner changed from tbd to GeorgSWeber
  • Status changed from new to assigned
  • Summary changed from R.py doctest fails for non-english locale to [with patch, needs review] R.py doctest fails for non-english locale
  • Authors set to Georg S. Weber

comment:2 Changed 4 years ago by was

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Summary changed from [with patch, needs review] R.py doctest fails for non-english locale to [with patch, positive review] R.py doctest fails for non-english locale

merged in sage-4.1.2.rc1...

Note: See TracTickets for help on using tickets.