Ticket #7082 (closed defect: invalid)

Opened 4 years ago

Last modified 4 years ago

SageNB -- WorksheetProcess is an old-style class

Reported by: timdumol Owned by: boothby
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords: sagenb notebook
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Tim Dumol Merged in:
Dependencies: Stopgaps:

Description

WorksheetProcess? in worksheet_process.py does not inherit from object

Attachments

trac_7082-old-style-class.patch Download (20.0 KB) - added by timdumol 4 years ago.
Makes WorksheetProcess a new-style class. Also fixes some docstring problems, and updates misc.py

Change History

Changed 4 years ago by timdumol

Makes WorksheetProcess a new-style class. Also fixes some docstring problems, and updates misc.py

comment:1 Changed 4 years ago by was

  • Summary changed from SageNB -- WorksheetProcess is an old-style class to [with patch; needs work] SageNB -- WorksheetProcess is an old-style class

I applied this patch and there are a spectacular number of merge conflicts: 

flat:sagenb wstein$ hg import trac_7082-old-style-class.patch 
applying trac_7082-old-style-class.patch
patching file sagenb/interfaces/reference.py
Hunk #1 FAILED at 79
1 out of 1 hunks FAILED -- saving rejects to file sagenb/interfaces/reference.py.rej
patching file sagenb/interfaces/reference.py
Hunk #1 FAILED at 79
1 out of 1 hunks FAILED -- saving rejects to file sagenb/interfaces/reference.py.rej
patching file sagenb/interfaces/worksheet_process.py
Hunk #1 FAILED at 17
1 out of 1 hunks FAILED -- saving rejects to file sagenb/interfaces/worksheet_process.py.rej
patching file sagenb/misc/sageinspect.py
Hunk #1 FAILED at 11
Hunk #2 FAILED at 223
Hunk #3 FAILED at 265
Hunk #4 FAILED at 307
Hunk #5 succeeded at 396 with fuzz 2 (offset 4 lines).
Hunk #6 FAILED at 624
Hunk #7 FAILED at 663
6 out of 7 hunks FAILED -- saving rejects to file sagenb/misc/sageinspect.py.rej
patching file sagenb/interfaces/reference.py
Hunk #1 FAILED at 79
1 out of 1 hunks FAILED -- saving rejects to file sagenb/interfaces/reference.py.rej
patching file sagenb/interfaces/worksheet_process.py
Hunk #1 FAILED at 17
1 out of 1 hunks FAILED -- saving rejects to file sagenb/interfaces/worksheet_process.py.rej
patching file sagenb/misc/sageinspect.py
Hunk #1 FAILED at 11
Hunk #2 FAILED at 223
Hunk #3 FAILED at 265
Hunk #4 FAILED at 307
Hunk #5 succeeded at 401 with fuzz 2 (offset 9 lines).
Hunk #6 FAILED at 624
Hunk #7 FAILED at 663
6 out of 7 hunks FAILED -- saving rejects to file sagenb/misc/sageinspect.py.rej
patching file sagenb/interfaces/worksheet_process.py
Hunk #1 FAILED at 17
1 out of 1 hunks FAILED -- saving rejects to file sagenb/interfaces/worksheet_process.py.rej
patching file sagenb/misc/sageinspect.py
Hunk #1 FAILED at 11
Hunk #2 FAILED at 223
Hunk #3 FAILED at 265
Hunk #4 FAILED at 307
Hunk #5 succeeded at 406 with fuzz 2 (offset 14 lines).
Hunk #6 FAILED at 624
Hunk #7 FAILED at 663
6 out of 7 hunks FAILED -- saving rejects to file sagenb/misc/sageinspect.py.rej
abort: patch failed to apply

Could you rebase it against my repo?  http://sage.math.washington.edu:8100/

comment:2 Changed 4 years ago by timdumol

  • Summary changed from [with patch; needs work] SageNB -- WorksheetProcess is an old-style class to [Please close] SageNB -- WorksheetProcess is an old-style class

The changes in this patch have already been included.

comment:3 Changed 4 years ago by mhansen

  • Status changed from needs_work to closed
  • Resolution set to invalid
  • Milestone changed from sage-4.3 to sage-duplicate/invalid/wontfix

comment:4 Changed 4 years ago by mvngu

  • Summary changed from [Please close] SageNB -- WorksheetProcess is an old-style class to SageNB -- WorksheetProcess is an old-style class
Note: See TracTickets for help on using tickets.