Ticket #6909 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] move some commutative algebra to libSingular functions interface

Reported by: malb Owned by: malb
Priority: major Milestone: sage-4.2
Component: commutative algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Michael Brickenstein, Burcin Erocal
Authors: Martin Albrecht Merged in: sage-4.2.alpha0
Dependencies: Stopgaps:

Description

Implement a couple of functions using the new libsingular functions interface (#6628).

Attachments

libsingular_more_functions.patch Download (22.7 KB) - added by malb 4 years ago.
trac_6909-libsingular_more_functions.patch Download (22.3 KB) - added by burcin 4 years ago.
rebased to 4.1.2.rc0

Change History

Changed 4 years ago by malb

comment:1 Changed 4 years ago by malb

  • Summary changed from [with patch, needs review] to [with patch, needs review] move some commutative algebra to libSingular functions interface

The attached patch

  • implements a Pythonic interface to the Singular options
  • fixes a bug where local orderings were not used correctly
  • switches groebner_basis() and elimination_ideal() to libsingular.

For most functions on multivariate polynomial ideals we first need to wrap libSingular lists since many functions return lists. This would require an updated SPKG.

comment:2 Changed 4 years ago by PolyBoRi

Hi, I spent 10 minutes reading the code and like it (this is not a formal review). Cheers, Michael

Changed 4 years ago by burcin

rebased to 4.1.2.rc0

comment:3 Changed 4 years ago by burcin

  • Status changed from needs_review to positive_review
  • Reviewers set to Michael Brickenstein, Burcin Erocal
  • Summary changed from [with patch, needs review] move some commutative algebra to libSingular functions interface to [with patch, positive review] move some commutative algebra to libSingular functions interface
  • Milestone changed from sage-4.1.3 to sage-4.1.2

Positive review.

Apply only attachment:trac_6909-libsingular_more_functions.patch Download, which is a rebase of Martin's patch to 4.1.2.rc0.

comment:4 Changed 4 years ago by mhansen

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.2.alpha0
Note: See TracTickets for help on using tickets.