Ticket #6896 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] update README.txt about GCC versions

Reported by: mvngu Owned by: tba
Priority: major Milestone: sage-4.1.2
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers: William Stein
Authors: joskarsson Merged in: Sage 4.1.2.alpha1
Dependencies: Stopgaps:

Description

The README.txt file in SAGE_ROOT should be updated on the supported versions of GCC. See this  sage-support thread for some background.

Attachments

trac_6896-readme.patch Download (11.7 KB) - added by mvngu 4 years ago.
don't apply this patch
README.2.txt Download (9.5 KB) - added by joskarsson 4 years ago.
Updates to Supperted Compilers
README.txt.trac-6896-1.patch Download (516 bytes) - added by joskarsson 4 years ago.
Patch to README.txt, changing supported compilers
README.txt Download (9.5 KB) - added by mvngu 4 years ago.
with changes suggested by README.txt.trac-6896-1.patch

Change History

comment:1 Changed 4 years ago by mvngu

  • Summary changed from update README.txt about GCC versions to [with patch, needs review] update README.txt about GCC versions
  • Authors set to Minh Van Nguyen

An updated README.txt is attached with this ticket. That file is not under revision control. But if you want to see the changes new to this updated version, refer to trac_6896-readme.patch. That patch is not meant to be applied.

comment:2 Changed 4 years ago by was

  • Summary changed from [with patch, needs review] update README.txt about GCC versions to [with patch, needs work] update README.txt about GCC versions
  1. This is redundant: 
    Sage builds with GCC >= 4.x and GCC >= 4.1.x.

how about just 

Sage requires GCC >= 4.x.

Changed 4 years ago by mvngu

don't apply this patch

comment:3 Changed 4 years ago by mvngu

  • Summary changed from [with patch, needs work] update README.txt about GCC versions to [with patch, needs review] update README.txt about GCC versions

New README.txt is up together with corresponding patch file. Don't apply the patch; it's there to show differences between the README.txt currently in Sage and the new README.txt.

Changed 4 years ago by joskarsson

Updates to Supperted Compilers

Changed 4 years ago by joskarsson

Patch to README.txt, changing supported compilers

comment:4 Changed 4 years ago by was

  • Summary changed from [with patch, needs review] update README.txt about GCC versions to [with patch, positive review] update README.txt about GCC versions

The relevant lines of the file README.2.txt looks very good to me.

Changed 4 years ago by mvngu

with changes suggested by README.txt.trac-6896-1.patch

comment:5 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Reviewers set to William Stein
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha1
  • Authors changed from Minh Van Nguyen to joskarsson

Applied the changes suggested in README.txt.trac-6896-1.patch and the updated README.txt is attached. See README.txt as README.2.txt doesn't have the changes in README.txt.trac-6896-1.patch.

joskarsson --- Please fill in your real name in the "Author(s):" field. That way, your contribution is properly acknowledged.

Note: See TracTickets for help on using tickets.