Ticket #6853 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Templating tag typo

Reported by: mpatel Owned by: boothby
Priority: trivial Milestone: sage-4.1.2
Component: notebook Keywords:
Cc: timdumol Work issues:
Report Upstream: Reviewers: Willem Jan Palenstijn
Authors: Mitesh Patel Merged in: Sage 4.1.2.alpha0
Dependencies: Stopgaps:

Description

There is an incomplete closing script tag in server/notebook/templates/notebook/head.tmpl: 

<script type="text/javascript" src="/javascript/sage3d.js"></script

I don't know if this actually affects any rendering engine. I just noticed it when viewing the source for a worksheet page in Firefox.

This depends on #6568.

Attachments

trac_6853-template_typo.patch Download (1.0 KB) - added by mpatel 4 years ago.
Apply only this patch.

Change History

Changed 4 years ago by mpatel

Apply only this patch.

comment:1 Changed 4 years ago by mpatel

I'm not sure about why these lines appear in the patch: 

-{% endmacro %}
\ No newline at end of file
+{% endmacro %}

These also appear in the new patch at #6459.

comment:2 Changed 4 years ago by wjp

  • Summary changed from [with patch, needs review] Templating tag typo to [with patch, positive review] Templating tag typo

Those lines mean the file that's being patched had no newline and the end of the file, but the new one does. (That's an improvement.) In short, nothing to worry about.

Anyway, this patch applies (after #6568) and is clearly correct, so positive review.

comment:3 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Reviewers set to Willem Jan Palenstijn
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha0
Note: See TracTickets for help on using tickets.