Ticket #6850 (closed enhancement: fixed)
[with patch, positive review] follow-up to #6531: really add ring.pyx to reference manual
| Reported by: | mvngu | Owned by: | tba |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.1.2 |
| Component: | documentation | Keywords: | Rings documentation |
| Cc: | davidloeffler, cremona | Work issues: | |
| Report Upstream: | Reviewers: | John Cremona | |
| Authors: | Minh Van Nguyen | Merged in: | Sage 4.1.2.alpha0 |
| Dependencies: | Stopgaps: |
Description
The patch trac_6531-restify_generic_ring-rebase.patch at #6531 was intended to provide documentation and doctests for the module sage/rings/ring.pyx. It was also meant to add that module to the reference manual, but doesn't really make any changes to doc/en/reference/rings.rst to allow this.
Attachments
-
trac_6850-add-ring.patch
(7.6 KB) -
added by mvngu 4 years ago.
- depends on #6531
Change History
Changed 4 years ago by mvngu
-
attachment
trac_6850-add-ring.patch
added
comment:1 Changed 4 years ago by mvngu
- Cc davidloeffler, cremona added
- Authors set to Minh Van Nguyen
The patch trac_6850-add-ring.patch actually adds the module sage/rings/ring.pyx to the reference manual and fixes some typos found in that module. It depends on #6531.
comment:2 Changed 4 years ago by mvngu
- Summary changed from follow-up to #6531: really add ring.pyx to reference manual to [with patch, needs review] follow-up to #6531: really add ring.pyx to reference manual
comment:3 Changed 4 years ago by cremona
- Keywords Rings documentation added
- Reviewers set to John Cremona
- Summary changed from [with patch, needs review] follow-up to #6531: really add ring.pyx to reference manual to [with patch, with positive review] follow-up to #6531: really add ring.pyx to reference manual
Sorry, that was my fault -- David's original patch did make the necessary changes to the .rst file but somehow that was carried forward into the patch I made.
The patch applies and builds fine (on top of the new one at #6531).
comment:4 Changed 4 years ago by mvngu
- Status changed from new to closed
- Resolution set to fixed
- Merged in set to Sage 4.1.2.alpha0
- Summary changed from [with patch, with positive review] follow-up to #6531: really add ring.pyx to reference manual to [with patch, positive review] follow-up to #6531: really add ring.pyx to reference manual
Note: See
TracTickets for help on using
tickets.
depends on #6531