Ticket #6826 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] magma_free interface is broken

Reported by: ncalexan Owned by: was
Priority: major Milestone: sage-4.1.2
Component: interfaces Keywords: magma free internet interface
Cc: was Work issues:
Report Upstream: Reviewers: Mike Hansen, Robert Bradshaw
Authors: Nick Alexander Merged in: Sage 4.1.2.alpha4
Dependencies: Stopgaps:

Description

The magma free interface has changed slightly. The attached patch updates the interface.

Attachments

trac_6826-magma_free.patch Download (760 bytes) - added by ncalexan 4 years ago.

Change History

Changed 4 years ago by ncalexan

comment:1 follow-up: ↓ 2 Changed 4 years ago by mhansen

It looks like it is still "input" rather than "commands" when looking at the source for  http://magma.maths.usyd.edu.au/calc/.

comment:2 in reply to: ↑ 1 Changed 4 years ago by ncalexan

Replying to mhansen:

It looks like it is still "input" rather than "commands" when looking at the source for  http://magma.maths.usyd.edu.au/calc/.

Yep, it did to me too. All I know is that it didn't work before the patch, and it now works with the patch. That's the important part -- is that the same for you?

comment:3 Changed 4 years ago by mhansen

It works both before and after for me. Maybe the test input that I'm using is too simple.

comment:4 Changed 4 years ago by robertwb

  • Summary changed from [with patch, needs review] magma_free interface is broken to [with patch, positive review] magma_free interface is broken

It's id="input" name="commands".

It still works for me too, but this should probably be fixed for consistencies sake.

comment:5 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Reviewers set to Mike Hansen, Robert Bradshaw
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha3

comment:6 Changed 4 years ago by mvngu

  • Merged in changed from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

Note: See TracTickets for help on using tickets.