Ticket #6809 (closed enhancement: fixed)
abstract_methods_of_class
| Reported by: | nthiery | Owned by: | nthiery |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.2 |
| Component: | misc | Keywords: | abstract methods |
| Cc: | sage-combinat | Work issues: | |
| Report Upstream: | Reviewers: | Florent Hivert | |
| Authors: | Nicolas M. Thiéry | Merged in: | sage-4.2.alpha1 |
| Dependencies: | Stopgaps: |
Description
Implement a utility abstract_methods_of_class which lists all the optional and mandatory abstract methods of the class.
Attachments
Change History
Changed 4 years ago by hivert
-
attachment
trac_6809_abstract_methods_of_class.2.patch
added
New version with is_optional method
comment:2 Changed 4 years ago by hivert
- Status changed from new to needs_review
- Reviewers changed from Franco Saliola? to Florent Hivert
I'm done reviewing this patch. It is good upto a small detail: the code access to a private attribute. I've added an accessor method.
I just uploaded a new version of the patch after review which add a is_optional method for better encapsulation (as suggested by former comment in the code).
Nicolas: please add a positive review when you finished reviewing my changes.
Cheers,
Florent
comment:3 Changed 4 years ago by hivert
During his review of my change Nicolas spotted a missing blank line after 'EXAMPLE::'... I'm re-uploading the patch...
Cheers,
Florent
Changed 4 years ago by hivert
-
attachment
trac_6809_abstract_methods_of_class.3.patch
added
Added missing blank line
