Ticket #6809 (closed enhancement: fixed)

Opened 13 months ago

Last modified 11 months ago

abstract_methods_of_class

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.2
Component: misc Keywords: abstract methods
Cc: sage-combinat Author(s): Nicolas M. Thiéry
Report Upstream: Reviewer(s): Florent Hivert
Merged in: sage-4.2.alpha1 Work issues:

Description

Implement a utility abstract_methods_of_class which lists all the optional and mandatory abstract methods of the class.

Attachments

trac_6809_abstract_methods_of_class.patch Download (3.4 KB) - added by nthiery 13 months ago.
trac_6809_abstract_methods_of_class.2.patch Download (3.9 KB) - added by hivert 11 months ago.
New version with is_optional method
trac_6809_abstract_methods_of_class.3.patch Download (3.9 KB) - added by hivert 11 months ago.
Added missing blank line

Change History

Changed 13 months ago by nthiery

Changed 11 months ago by nthiery

Changed 11 months ago by hivert

New version with is_optional method

Changed 11 months ago by hivert

  • status changed from new to needs_review
  • reviewer changed from Franco Saliola? to Florent Hivert

I'm done reviewing this patch. It is good upto a small detail: the code access to a private attribute. I've added an accessor method.

I just uploaded a new version of the patch after review which add a is_optional method for better encapsulation (as suggested by former comment in the code).

Nicolas: please add a positive review when you finished reviewing my changes.

Cheers,

Florent

Changed 11 months ago by hivert

During his review of my change Nicolas spotted a missing blank line after 'EXAMPLE::'... I'm re-uploading the patch...

Cheers,

Florent

Changed 11 months ago by hivert

Added missing blank line

Changed 11 months ago by hivert

  • status changed from needs_review to positive_review

After Blank line added, Nicolas allows me to put the positive review.

Only apply the last trac_6809_abstract_methods_of_class.3.patch

Florent

Changed 11 months ago by mhansen

  • status changed from positive_review to closed
  • resolution set to fixed
  • merged set to sage-4.2.alpha1
Note: See TracTickets for help on using tickets.