Ticket #6804 (closed defect: fixed)

Opened 4 years ago

Last modified 16 months ago

Permutation.weak_excedences inconsistency

Reported by: schilly Owned by: mhansen
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords:
Cc: mjo Work issues:
Report Upstream: N/A Reviewers: Nathann Cohen
Authors: Michael Orlitzky Merged in: sage-5.0.beta2
Dependencies: Stopgaps:

Description

Either code or docstring is wrong in 4.1.1, "=" vs. ">=": 

Returns all the numbers self[i] such that self[i] = i+1

if self[i] >= i + 1:
    res.append(self[i])

Attachments

sage-trac_6804.patch Download (662 bytes) - added by mjo 17 months ago.
Fix the docstring.

Change History

Changed 17 months ago by mjo

Fix the docstring.

comment:1 Changed 17 months ago by mjo

  • Cc mjo added
  • Status changed from new to needs_review
  • Report Upstream set to N/A
  • Authors set to Michael Orlitzky

I found a reference; the bug was in the docstring.

comment:2 Changed 16 months ago by ncohen

  • Status changed from needs_review to positive_review

Well, then...:-)

Nathann

comment:3 Changed 16 months ago by jdemeyer

  • Reviewers set to Nathann Cohen

comment:4 Changed 16 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta2
Note: See TracTickets for help on using tickets.