Ticket #6760 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

error in quaternion algebra ideal basis

Reported by: robertwb Owned by: tbd
Priority: major Milestone: sage-4.3
Component: algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers: Alex Ghitza
Authors: Robert Bradshaw Merged in: sage-4.3.alpha0
Dependencies: Stopgaps:

Description 

sage: R.<i,j,k> = QuaternionAlgebra(-1, -13)        
sage: I = R.ideal([2+i, 3*i, 5*j, j+k]); I
Fractional ideal (2 + i, 3*i, j + k, 5*k)
sage: I.free_module()
------------------------------------------------------------
Traceback (most recent call last):
  File "<ipython console>", line 1, in <module>
  File "/Users/robert/sage/sage-4.0/local/lib/python2.6/site-packages/sage/algebras/quatalg/quaternion_algebra.py", line 1503, in free_module
    M = self.hermite_basis_matrix().row_module(ZZ)
AttributeError: 'QuaternionFractionalIdeal_rational' object has no attribute 'hermite_basis_matrix'

Attachments

6760-quatalg-free-module.patch Download (777 bytes) - added by robertwb 4 years ago.
trac_6760_doctest.patch Download (1.1 KB) - added by AlexGhitza 4 years ago.
apply after the previous patch

Change History

Changed 4 years ago by robertwb

comment:1 Changed 4 years ago by robertwb

  • Summary changed from error in quaternion algebra ideal basis to [with patch, needs review] error in quaternion algebra ideal basis

I think this is the right fix, but someone more familiar with the code should take a look.

comment:2 Changed 4 years ago by AlexGhitza

  • Summary changed from [with patch, needs review] error in quaternion algebra ideal basis to error in quaternion algebra ideal basis
  • Authors set to Robert Bradshaw

comment:3 Changed 4 years ago by AlexGhitza

  • Reviewers set to Alex Ghitza

Looks good to me. I am adding a patch with a doctest (just the example that was given above).

Robert, if you're happy with the second patch, please change this to a positive review.

Changed 4 years ago by AlexGhitza

apply after the previous patch

comment:4 Changed 4 years ago by robertwb

  • Status changed from needs_review to positive_review

comment:5 Changed 4 years ago by mhansen

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.3.alpha0
Note: See TracTickets for help on using tickets.