Ticket #673 (closed defect: fixed)

Opened 6 years ago

Last modified 4 years ago

[with patch; positive review] Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity

Reported by: mabshoff Owned by: failure
Priority: major Milestone: sage-3.4.1
Component: doctest coverage Keywords: Solaris 10, doctest, real double
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

sage -t  rings/real_double.pyx                              **********************************************************************
File "real_double.pyx", line 952:
    sage: RDF(0).log()
Expected:
    -inf
Got:
    -Infinity
**********************************************************************
File "real_double.pyx", line 954:
    sage: RDF(-1).log()
Expected:
    nan
Got:
    -NaN
**********************************************************************

Attachments

trac_673.patch Download (6.1 KB) - added by was 4 years ago.
trac_673_part2.patch Download (2.7 KB) - added by was 4 years ago.

Change History

comment:1 Changed 6 years ago by mabshoff

  • Owner changed from was to failure
  • Component changed from packages to doctest

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity to [partially fixed?] Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity

Some of this might have been fixed by #848.

Cheers,

Michael

comment:3 Changed 4 years ago by was

  • Summary changed from [partially fixed?] Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity to [with patch; needs review] Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity
  • Milestone changed from sage-3.4.2 to sage-3.4.1

Changed 4 years ago by was

Changed 4 years ago by was

comment:4 Changed 4 years ago by mabshoff

  • Summary changed from [with patch; needs review] Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity to [with patch; positive review] Solaris 10: rings/complex_double.pyx doctests failure: inf vs. Infinity

Positive review for both patches. This also makes the printing of NaN and Infinity consistent with CC. At the same time it fixes three more doctesting issues on Solaris where the libc caused different printouts.

Cheers,

Michael

comment:5 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged both patches in Sage 3.4.1.rc2.

Cheers,

Michael

Note: See TracTickets for help on using tickets.