Ticket #6620 (closed enhancement: fixed)

Opened 13 months ago

Last modified 12 months ago

[with patch, positive review] add a method to the Gap class to access elements of records

Reported by: saliola Owned by: was
Priority: major Milestone: sage-4.1.2
Component: interfaces Keywords:
Cc: nborie, wdj Author(s): Franco Saliola
Report Upstream: Reviewer(s): David Joyner, Minh Van Nguyen
Merged in: Sage 4.1.2.alpha0 Work issues:

Description

Accessing elements of GAP records should be easier. 

            sage: rec = gap('rec( a := 1, b := "2" )')
            sage: gap.get_record_element(rec, 'a')
            1
            sage: gap.get_record_element(rec, 'b')
            2

Attachments

trac_6620.patch Download (1.3 KB) - added by saliola 13 months ago.
trac_6620-reviewer.patch Download (0.9 KB) - added by mvngu 12 months ago.
reviewer patch; fix typos in ReST format

Change History

Changed 13 months ago by saliola

Changed 13 months ago by saliola

  • cc wdj added
  • summary changed from add a method to the Gap class to access elements of records to [with patch; needs review] add a method to the Gap class to access elements of records
  • author set to Franco Saliola

Changed 13 months ago by wdj

  • summary changed from [with patch; needs review] add a method to the Gap class to access elements of records to [with patch; positive review] add a method to the Gap class to access elements of records

Applies fine to 4.1.1.a0, and passes sage -testall. I also played with it a bit and could not find any bugs and the docstrings seem fine.

Changed 12 months ago by mvngu

reviewer patch; fix typos in ReST format

Changed 12 months ago by mvngu

  • summary changed from [with patch; positive review] add a method to the Gap class to access elements of records to [with patch, positive review] add a method to the Gap class to access elements of records

The patch trac_6620-reviewer.patch fixes some typos in ReST formatting introduced by trac_6620.patch. Such typos would result in warnings when (re)building the reference manual.

Changed 12 months ago by mvngu

  • status changed from new to closed
  • reviewer set to David Joyner, Minh Van Nguyen
  • resolution set to fixed
  • merged set to Sage 4.1.2.alpha0

Merged patches in this order:

  1. trac_6620.patch
  2. trac_6620-reviewer.patch
Note: See TracTickets for help on using tickets.